Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report a typo in README.md doc(in master branch) #410

Closed
pagesus opened this issue Nov 12, 2023 · 1 comment
Closed

Report a typo in README.md doc(in master branch) #410

pagesus opened this issue Nov 12, 2023 · 1 comment

Comments

@pagesus
Copy link

pagesus commented Nov 12, 2023

In README.md doc,
(1) I find that in section Version 3 breaking changes said: the ParseResult object no longer depends on the parser.
(2) But I also find in section Basics said: Note that the result of options.parse should only be used as long as the options object that created it is in scope.

I review the code, and find the ParseResult is independent of parser, so the description in (2) is a typo?

@jarro2783
Copy link
Owner

Yes you are right. I missed that later section when I first made that change. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants