Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI system #5

Closed
jart opened this issue Jun 27, 2020 · 7 comments
Closed

Set up CI system #5

jart opened this issue Jun 27, 2020 · 7 comments
Assignees

Comments

@jart
Copy link
Owner

jart commented Jun 27, 2020

It'd be nice to have something like Travis to help run tests quickly during the PR code review process.

@negbie
Copy link
Collaborator

negbie commented Jun 29, 2020

@jart I have added github actions to the dialog branch. It will run

go test $(go list ./... | grep -Ev 'dialog|example|fone|util')

on every pull, pr request. The tests under the example folder are integration tests right?

@jart
Copy link
Owner Author

jart commented Jun 29, 2020

Awesome! That should make pull requests a lot nicer.

If I remember correctly, some of the examples were written under the assumption that a FreeSWITCH and Asterisk server is running on the local network for integration testing. I wouldn't worry too much about those. Making sure they build though is important.

@negbie
Copy link
Collaborator

negbie commented Jun 29, 2020

Ok so a further improvement would be to let github actions spin up a FreeSWITCH and Asterisk container and do the integration tests.

@jart
Copy link
Owner Author

jart commented Jun 30, 2020

Unit testing should be good enough. Asterisk and FreeSWITCH are enormous.

@negbie
Copy link
Collaborator

negbie commented Jun 30, 2020

Yeah that's true. Ok let me close this.

@negbie negbie closed this as completed Jun 30, 2020
@jart
Copy link
Owner Author

jart commented Jun 30, 2020

I love the little green checkmarks by the way. Thank you!

@negbie
Copy link
Collaborator

negbie commented Jul 1, 2020

Me too ;) Your welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants