-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CI system #5
Comments
@jart I have added github actions to the dialog branch. It will run go test $(go list ./... | grep -Ev 'dialog|example|fone|util') on every pull, pr request. The tests under the example folder are integration tests right? |
Awesome! That should make pull requests a lot nicer. If I remember correctly, some of the examples were written under the assumption that a FreeSWITCH and Asterisk server is running on the local network for integration testing. I wouldn't worry too much about those. Making sure they build though is important. |
Ok so a further improvement would be to let github actions spin up a FreeSWITCH and Asterisk container and do the integration tests. |
Unit testing should be good enough. Asterisk and FreeSWITCH are enormous. |
Yeah that's true. Ok let me close this. |
I love the little green checkmarks by the way. Thank you! |
Me too ;) Your welcome! |
It'd be nice to have something like Travis to help run tests quickly during the PR code review process.
The text was updated successfully, but these errors were encountered: