Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cake to generate doc:site #3198

Merged
merged 1 commit into from
Oct 8, 2013
Merged

Conversation

tiye
Copy link

@tiye tiye commented Oct 7, 2013

Preview here: http://s.jiyinyiyong.info/coffee-script/index.html

Use highlight.js and eco to replace uv and erb which were previously used.
For the theme, I forked hightlight.js's tomorrow.css, make it look like current one as much as possible.
And I have checked, the obvious links on the page are working now.
Rakefile is removed in gh-pages branch.

Related issue: #2193 (comment)

@vendethiel
Copy link
Collaborator

maybe we should extract the doc generation to another file?

@tiye
Copy link
Author

tiye commented Oct 7, 2013

@Nami-Doc The first thing I want to do is making the generator work without spending time configuring the evironment. So I haven't thought about that, and what do you mean by extracting to another file?

@epidemian
Copy link
Contributor

Awesome contribution, @jiyinyiyong 👍

I think @Nami-Doc means to extract the code_for helper into another file, to leave the Cakefile as slim as possible (BTW, if you're gonna change that, may i suggest to call it codeFor, to stick to the JS naming convention?).

@vendethiel
Copy link
Collaborator

Yeah, that's basically what I meant :).

@tiye
Copy link
Author

tiye commented Oct 8, 2013

I don't think it's good idea to create a new file or folder a project root.
But I tried to put the definition of code_for out of task doc:site in the commit.

@@ -41,6 +43,27 @@ run = (args, cb) ->
log = (message, color, explanation) ->
console.log color + message + reset + ' ' + (explanation or '')

# Render code into site
code_for = (file, executable=false, show_load=true) ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces around =

@michaelficarra
Copy link
Collaborator

Awesome. Thanks so much for this, @jiyinyiyong. This will help us finally create release tasks. Merging.

michaelficarra added a commit that referenced this pull request Oct 8, 2013
@michaelficarra michaelficarra merged commit 95ede2c into jashkenas:gh-pages Oct 8, 2013
@vendethiel
Copy link
Collaborator

Good job !

@michaelficarra michaelficarra mentioned this pull request Jan 20, 2014
This was referenced Jan 28, 2014
@tiye
Copy link
Author

tiye commented Feb 10, 2014

So @xixixao 's PR #3333 for master has replaced this one. Anyone who finds this issue should read #3333 for details.

Personally I'm still confusing why these merged code is removed. coffee-js/coffee-script was based on that code (already migrated now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants