Use stdio option instead of customFds #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no need to regenerate the docs. That will be done during a release. |
dtaniwaki
force-pushed
the
fix-deprecated-option
branch
from
e48f70f
to
1301390
Compare
|
Thanks @michaelficarra , |
|
👍 |
|
👍 x 💯 - this pops up all the time for users of iojs and node-v0.12. In case it matters, it was deprecated over 3 years ago (node-v0.5.11), so this has been a long time coming. |
jashkenas
added a commit
that referenced
this pull request
Mar 6, 2015
Use stdio option instead of customFds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customFds option in spawn is deprecated.
http://nodejs.org/docs/latest/api/child_process.html#child_process_child_process_spawn_command_args_options
Although it's actually converted for now, I don't want to see the annoying deprecated message.
https://github.com/joyent/node/blob/master/lib/child_process.js#L808
Could you consider to merge this?