Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alternate alerts when vitals not present #75

Merged
merged 5 commits into from
Mar 17, 2024

Conversation

DerickJohnson
Copy link
Contributor

This will utilize the /api/solar_powerwall endpoint to populate the alerts array if devices (through vitals) are not present. Let me know if you want it simplified to not include the outer 'if'. I included it for clarity, to show the distinct paths, but it can also be simplified if needed (since it won't loop through devices that aren't present).

I also only used the fallback if alertsonly was true, since we don't have device specific information in that setup.

This should be automatically picked up by the alerts/pw endpoint since the format is the same.

I tested it locally using the /alerts endpoint, but might be good to validate that it still uses vitals if they are present (it should). I am on the later firmware where it's no longer present (23.44).

Let me know if you'd like anything changed!

@DerickJohnson
Copy link
Contributor Author

Let me add some error handling actually, in case that endpoint goes

@DerickJohnson DerickJohnson reopened this Mar 17, 2024
@DerickJohnson
Copy link
Contributor Author

Ok, ready to be reviewed!

@jasonacox
Copy link
Owner

Looks good @DerickJohnson ! Thanks! 🙏

I'll add release notes and start the merge.

@jasonacox jasonacox merged commit 58e685b into jasonacox:main Mar 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants