Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace request with got to be more lightweight #1

Closed
JasonBoy opened this issue Sep 13, 2017 · 4 comments
Closed

replace request with got to be more lightweight #1

JasonBoy opened this issue Sep 13, 2017 · 4 comments
Labels
enhancement

Comments

@JasonBoy
Copy link
Owner

request is kind of bloated, to make the project more lightweight, got is a good replacement, which is promise based by defualt
@JasonBoy
Copy link
Owner Author

JasonBoy commented Dec 5, 2017

could be some issues since a http request stream cannot pipe to got directly 😢

@JasonBoy
Copy link
Owner Author

The functionalities of request and got have a little more differences, so close this

@JasonBoy
Copy link
Owner Author

JasonBoy commented Jan 4, 2019

prepared, will be done in near future

@JasonBoy JasonBoy reopened this Jan 4, 2019
@JasonBoy JasonBoy mentioned this issue Jan 4, 2019
Merged
@JasonBoy JasonBoy removed the question label Jan 4, 2019
@JasonBoy
Copy link
Owner Author

JasonBoy commented Jan 7, 2019

🎉 Finally done on #19

@JasonBoy JasonBoy closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JasonBoy