Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gyp rebuild noble-uwp error #17

Closed
hoffmannjan opened this issue Jun 9, 2017 · 8 comments
Closed

node-gyp rebuild noble-uwp error #17

hoffmannjan opened this issue Jun 9, 2017 · 8 comments

Comments

@hoffmannjan
Copy link

Hi,

I'm trying to do electron-rebuild (as well as node-gyp rebuild which is the part of electron-rebuild) noble-uwp and after installing Windows SDK (matching version) and VS 2015 Express and also windows-build-tools i got this error

https://pastebin.com/mfYu34uQ

Any ideas?

I've never messed with any flags, neither in system settings nor in noble-uwp configuration files.

@hoffmannjan hoffmannjan changed the title node-gyp rebuild noble-uwp node-gyp rebuild noble-uwp error Jun 9, 2017
@jasongin
Copy link
Owner

jasongin commented Jun 9, 2017

Because this package includes 7 separate native modules, not just one, node-gyp rebuild alone doesn't do the right thing. That is why there is a build.cmd there.

I don't know how you can integrate that into electron-rebuild; I don't have experience with Electron development.

I have thought about separating the 7 UWP modules into npm dependency packages, so that node-pre-gyp can work. I guess that would also solve this problem.

@hoffmannjan
Copy link
Author

Cool , the build.cmd do the trick, thanks for answer ;).

@itome
Copy link
Contributor

itome commented Aug 20, 2017

Hi,
I also try to use noble-uwp in my electron project but I cannot.
The error log is next , by seeing this electron and noble-uwp is not completely matched.

Error: Cannot find module 'C:\Users\itome\Projects\MaBeeeElectron\node_modules\noble-uwp\uwp\windows.foundation\binding\electron-v1.6-win32-x64\binding.node'
    at Module._resolveFilename (module.js:470:15)
    at Function.Module._resolveFilename (C:\Users\itome\Projects\MaBeeeElectron\node_modules\electron\dist\resources\electron.asar\common\reset-search-paths.js:35:12)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\Users\itome\Projects\MaBeeeElectron\node_modules\noble-uwp\uwp\windows.foundation\lib\main.js:19:20)
    at Object.<anonymous> (C:\Users\itome\Projects\MaBeeeElectron\node_modules\noble-uwp\uwp\windows.foundation\lib\main.js:65:3)
    at Module._compile (module.js:571:32)
    at Module._extensions..js (module.js:580:10)
    at Object.require.extensions.(anonymous function) [as .js] (C:\Users\itome\Projects\MaBeeeElectron\node_modules\babel-register\lib\node.js:152:7)

@hoffmannjan seem to done well , so if you have some tips to run noble-uwp in electron. please tell me.
I already tried install.cmd (build.cmd renamed).

@Janneman84
Copy link

Janneman84 commented Aug 21, 2017

Same problem here. I'm not sure what to do to make it work in Electron. I tried using electron-rebuild but that gives me an error: Undefined variable module_name in uwp\windows.foundation\binding.gyp while loading dependencies of binding.gyp while trying to load binding.gyp.

I have both VS2015 and VS2017 installed. Although I have node 6.11 on my system it only seems to install for v48 and v57, according to the folder names in the binding folder.

Also are there differences between 32 and 64 bit Windows with regards to (Noble) UWP? My Electron application uses the 32 bit version (ia32), v1.4.15 to be precise, runs fine on 64 bit Windows too, don't know about the UWP part.

Any help would be greatly appreciated.

@itome
Copy link
Contributor

itome commented Aug 21, 2017

module_name is likely to be node-pre-gyp dependences. (nodejs/node-gyp#508)
And node-pre-gyp not completery supported by electron. (https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md)
But I cannot rebuild noble-uwp by node-gyp.

@itome
Copy link
Contributor

itome commented Aug 21, 2017

I opened new issue -> #31

@itome
Copy link
Contributor

itome commented Aug 21, 2017

@Janneman84 I found the way to rebuild noble-uwp for electron.
Please see this issue #31

@ghost
Copy link

ghost commented May 13, 2019

hi @hoffmannjan

can you help on how to use build.cmd, i am getting this error on an application that is build with electron-builder.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants