Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why "json" and not "jsonb" #8

Closed
jeffdoolittle opened this issue Oct 20, 2015 · 6 comments
Closed

Why "json" and not "jsonb" #8

jeffdoolittle opened this issue Oct 20, 2015 · 6 comments

Comments

@jeffdoolittle
Copy link
Contributor

I'm curious why documents are being stored with the "json" data type, and not the "jsonb" datatype?

https://github.com/JasperFx/Marten/blob/02e104e6b8d567e3dd86c4bf5d8112975ee7bb20/src/Marten/Generation/Templates/DocumentTable.txt#L4

http://stackoverflow.com/a/22910602/627205

@jeremydmiller
Copy link
Member

@jeffdoolittle At pretty well the exact time you posted this, I was having a conversation w/ @CoreyKaylor about exactly that. I'm going to switch to jsonb tomorrow morning and see if I can drop the "CAST" 's I have to do w/ the JSON type to query w/ anything that's not a string.

@jeremydmiller
Copy link
Member

or belay that, jsonb worked as is, but I'm still gonna try to optimize the queries for jsonb tomorrow.

@jeffdoolittle
Copy link
Contributor Author

That sounds great. I'd be interested in contributing as the project progresses as well. I was thinking about building a very similar project and then I saw you create this repo and I thought "why duplicate effort?" :)

@jeremydmiller
Copy link
Member

@jeffdoolittle Just added you to the gitter room for this. I'd happily take all the help we could get.

https://gitter.im/JasperFx/Marten?utm_source=share-link&utm_medium=link&utm_campaign=share-link

@jeremydmiller
Copy link
Member

Gonna close this one because we are on JSONB now;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants