Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS redirect does not work #5

Open
roumenh opened this issue Feb 19, 2024 · 7 comments
Open

iOS redirect does not work #5

roumenh opened this issue Feb 19, 2024 · 7 comments

Comments

@roumenh
Copy link

roumenh commented Feb 19, 2024

Hello,
first of all, big thanks for this extension!
I work with app that has both native (iOS and Android) implementation, and I was experimenting with your extension.

The Android part works just fine. I was briefly testing iOS part now, just to see if the redirect to AppStore will work, but once redirected to AppStore, it throws error.

If I emulate being iPhone in the browser and I open the source code, it feels like the iOS part is missing. There is only redirect to https://apps.apple.com/us/app/ but without any ID. I supplied ios Bundle in the settings.

The source code I see is:

image

Thank you for your reply! :) Roman

@roumenh
Copy link
Author

roumenh commented Feb 19, 2024

UPDATE:
I probably found the reason. The app I work on is only available in certain countries, in my case - in Sweden.
After research:
https://forums.developer.apple.com/forums/thread/105525
and once I found where you do get the appStoreId from - index.ts, 261
I realized this may be the cause of the issue.

@jauntybrain
Copy link
Owner

Hi @roumenh, thanks for reporting this! I see the problem with appstore ID lookup - didn't expect it to behave like that. I can fix this by adding an optional parameter for the appstore ID, what do you think?

The iOS redirection logic comes after all of the device logic, so if the device decided to open the application with the deeplink, it will do that before the script in index.html is executed. Therefore, everything in that script runs if the device didn't do anything about the link and loaded the webpage instead. Does that help or were you referring to some other logic?

@roumenh
Copy link
Author

roumenh commented Feb 19, 2024

@jauntybrain Thank you Pavel for your reply.
I even tried to add. the &country=se parameter after the bundleID, but the field validates as wrong bundle ID. I will leave the implementation to you, but yes, somehow to get the parameter in :)

I will then test the iOS redirection.

@wer-mathurin
Copy link

wer-mathurin commented Apr 11, 2024

@jauntybrain Any updates on this, we ave the same problem, because our app in available only in canada.\

This is a show stopper to use the extension for now, but as soon this will be fixed, we will use it for sure.

Very good documentation!

@pavel163
Copy link

pavel163 commented Oct 1, 2024

Hello. Any updates?

@pavel163
Copy link

pavel163 commented Oct 1, 2024

We use this in production and had to set one country for iOS. Our links stopped working

@miguel2211
Copy link

Hello, did anyone find a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants