Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue in release mode #87

Closed
muhammadkamel opened this issue Jun 17, 2023 · 5 comments
Closed

Security issue in release mode #87

muhammadkamel opened this issue Jun 17, 2023 · 5 comments

Comments

@muhammadkamel
Copy link

The ".env" file remains in the "flutter_assets" folder in the release after converting the APK file to a ZIP file and extracting it.

Screenshot 2023-06-17 at 7 45 32 PM

@java-james
Copy link
Owner

Hey @muhammadkamel thanks for the issue. Please see my explanation on #51 (comment)

This package is for managing front-end variables and is not intended for sensitive secrets.

@kevtechi
Copy link

@java-james , some way to put this as a big warning in the docs? I'm seeing a few open issues with developers who don't understand the difference between env and secrets.

@java-james
Copy link
Owner

@kev-techi Yep agree some learning info at the top of the readme should help developers understand and responsibly use this package

@java-james
Copy link
Owner

@kevtechi Added to readme in 5.2.1 :)
Thanks for the suggestion.

@kevtechi
Copy link

In hindsight, I could've made PR for this. Thanks for adding it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants