Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URIUtils loads error messages unnecessarily #52

Closed
Capstan opened this issue Apr 10, 2019 · 0 comments · Fixed by #54
Closed

URIUtils loads error messages unnecessarily #52

Capstan opened this issue Apr 10, 2019 · 0 comments · Fixed by #54

Comments

@Capstan
Copy link
Contributor

Capstan commented Apr 10, 2019

URIUtils.SCHEME_CHECKER.check() loads the error message bundle (which spawns a Thread to get the message source for the locale) even if the check would succeed. If this was a Future then it could be lazily loaded only if one of the checks failed.

This was discovered when upgrading json-schema-validator from v1.6.2 to v2.2.10, since the test harness we used for "small" tests inhibits thread creation, and meant that validator tests now must be promoted to "medium".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant