Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust licensing to declared project license #711

Merged

Conversation

matthiasblaesing
Copy link
Member

  • Headers of Java/C sources were adjusted to reflect to AL2.0/LGPL2.1 duallicensing
  • WeakIdentityHashMap was replaced with a custom minimal replacement implementation
  • Contribution.md was update to reflect the licensing

Closes: #252

@matthiasblaesing
Copy link
Member Author

@bhamail you handled the last license adjustment, could you have a look at this please? Basicly every source file (outside libffi source) either gained the LGPL2.1+AL2.0 header or the existing header was adjusted to match that.

@twall Could you please have a look at the only functional change: I replaced the copied WeakIdentityHashMap with WeakMemoryHolder, that is a minimal implementation of the used function set.

The primary concern of #252 is addressed by this, the two secondary points:

  • dlmalloc.c is PD, so I'd not change current handling (in all fairness I'm not sure what the point should be)
  • X.java claims it is base on - not derived from wmctrl - while you can see similarities this is not a copy

@matthiasblaesing
Copy link
Member Author

One thing I just noticed - the file headers I see mention LGPL 2.1 or (at your opinion) any later version..

So my question: Is the reduction to LGPL2.1 intended? If not I'll rework this to be reflected.

@matthiasblaesing
Copy link
Member Author

@bhamail @dblock @twall
I'd like you to give your feedback on this PR. I was not around when the license change happened, so I can't be sure what was intended.

Summary:
It was decided, that the project should also be licensed under the Apache License 2.0. This is reflected by the README.md from the root directory of the source code.

This is in contrast to LICENSE, which only speaks about LGPL 2.1 and AL 2.0, but drops the "or later" part of the LGPL wording in README.md.

The source code files then contradict this by one being licensed under LGPL 2.1 or later.

In addition source code that is licensed under pure AL 2.0 was copied into the tree (WeakIdentityHashMap).

So to clear this up:

  • Headers of Java/C sources were adjusted to reflect to AL2.0/LGPL2.1 (or later) duallicensing
  • WeakIdentityHashMap was replaced with a custom minimal replacement implementation
  • Contribution.md was update to reflect the licensing

@twall
Copy link
Contributor

twall commented Nov 3, 2016

This looks acceptable to me.

@dblock
Copy link
Member

dblock commented Nov 7, 2016

I vote 👍 too.

@twall I think this is your call to hit merge

@matthiasblaesing matthiasblaesing merged commit ea9de70 into java-native-access:master Nov 12, 2016
@matthiasblaesing
Copy link
Member Author

I merged the changes into master - thank you for checking and chiming in.

@matthiasblaesing matthiasblaesing deleted the licensing branch November 12, 2016 16:28
matthiasblaesing added a commit that referenced this pull request Mar 6, 2018
Adjust licensing to declared project license (followup for PR #711)
matthiasblaesing added a commit that referenced this pull request Mar 6, 2018
Adjust licensing to declared project license (followup for PR #711)
matthiasblaesing added a commit to matthiasblaesing/jna that referenced this pull request Feb 25, 2019
matthiasblaesing added a commit to matthiasblaesing/jna that referenced this pull request Mar 8, 2019
Changeset was reviewed by @twall via preparation PR,
commit 093e349
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
java-native-access#711)

…tail of Quiche

Motivation:

Our usage of quiche is an implementation detail so we should not leak it
to the user. We should convert from quiche errors to errors that are
defined in the RFC9000.

Modifications:

Remove QuicheError from public API and replace it by QuicTransportError.

Result:

Cleaner API without leaking implementation details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants