Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection will be cleared while playing #20

Open
JavaCS3 opened this issue Mar 29, 2020 · 0 comments
Open

Selection will be cleared while playing #20

JavaCS3 opened this issue Mar 29, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JavaCS3
Copy link
Owner

JavaCS3 commented Mar 29, 2020

Due to current framing strategy, xterm-player will refresh whole terminal if moving from a frame to next frame.

xterm-player/src/Player.ts

Lines 151 to 161 in 2462cdb

const frame = this._queue.frame(now)
if (this._lastframe === frame && now > this._lasttime) {
writeSync(this._term, frame.data(now, this._lasttime))
} else {
this._term.reset()
if (frame.prev) {
writeSync(this._term, frame.prev.snapshot() + frame.data(now))
} else {
writeSync(this._term, frame.data(now))
}
}

@JavaCS3 JavaCS3 added the bug Something isn't working label Mar 29, 2020
@JavaCS3 JavaCS3 self-assigned this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant