Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Missing .gitignore file #21

Closed
aalmiray opened this issue Mar 15, 2018 · 3 comments
Closed

Missing .gitignore file #21

aalmiray opened this issue Mar 15, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aalmiray
Copy link
Contributor

There's a .hgignore file at the root but no corresponding .gitignore file.

@bourgesl
Copy link
Contributor

Maybe just copy .hgignore to .gitignore ?

@aalmiray
Copy link
Contributor Author

Not really, no. The .hgignore file explicitly ignores .gitignore 😏 and there are other settings that no longer make sense.
The #22 PR addresses this issue.

@eugener eugener added enhancement New feature or request good first issue Good for newcomers labels Mar 24, 2018
@kevinrushforth
Copy link
Collaborator

I (almost) got bit by the lack of a .gitignore file when I somewhat carelessly did a "git add ." (never a good idea I know, but still would be nice to exclude the most common build files), so I'll take this issue.

This issue should be decoupled from any changes related to IDE files (e.g., issue #22 )

The .gitignore file is specific to the GitHub mirror and wouldn't need to back upstream (just like the .ci and .git directories are only in the sandbox). Conversely, any changes to IDE files would need to be done to address an upstream JBS issue, just like any other bug fix / enhancement.

Also, creating a .gitignore file, so that build artifacts, etc. are ignored, is independent of any proposed changes to the IDE configuration files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants