Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Gradle to java-10 #138

Closed
jeandersonbc opened this issue Aug 2, 2018 · 6 comments
Closed

Bring Gradle to java-10 #138

jeandersonbc opened this issue Aug 2, 2018 · 6 comments
Assignees

Comments

@jeandersonbc
Copy link
Collaborator

As Gradle is now the standard build tool for JPF, the future release (Java 10) must have Gradle support as well.

@jeandersonbc jeandersonbc self-assigned this Aug 2, 2018
@jeandersonbc
Copy link
Collaborator Author

Curretly, the gradle branch is in-sync with the java-10 branch.
In this link, there's a diff with the Travis log for java-10 (left) and for gradle (right).

Next step should be effectively updating gradle script to build and test JPF

@cyrille-artho
Copy link
Member

Is it possible to configure the diff such that some lines are ignored?
Normal diff has the -I option for this.

@jeandersonbc
Copy link
Collaborator Author

jeandersonbc commented Aug 2, 2018 via email

@gayanW
Copy link
Collaborator

gayanW commented Aug 2, 2018

Hi @jeandersonbc. It is good to hear that the two branches are in sync.

Here is a diff which shows all the changes that we've made to build.xml since the initial commit. It might be of help.

https://pastebin.com/fNCD6evF

@jeandersonbc
Copy link
Collaborator Author

I uploaded both logs without the Time Elapsed: ... field to remove the noise from the different measurements.

@cyrille-artho I ran sdiff and, in summary, those are the differences:

  • gradle branch has our ReporterResourcesTest
  • MethodTest was updated (one contributor added a test that was merged)

For reference: https://gist.github.com/jeandersonbc/a38250fc22b6228018a9a25b8603dff1#file-sdiff-output

I believe I'm good to go. I will keep working on the gradle branch but keeping it in sync with java-10 for future merge.

jeandersonbc added a commit that referenced this issue Aug 3, 2018
These files are temporary. I added temporarly to create a
Java 10 sandbox help me with the Gradle support.
@cyrille-artho
Copy link
Member

Resolved as part of PR#210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants