-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream @ 9acc1302 #9
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It literally says «Operating System system functions.»
add semicolon at end -> " return prop >= target.start && prop <= target.end;"
"return `undefined`" -> "returns `undefined`"
"on the paper" -> "on paper"
Grammar mistake (?)
According to the MDN precedence-table you've linked some precedence numbers are incorrect. Having a quick look at different language versions (French and Russian) this error may has to be corrected at every version.
"chapter" -> "article" 2x
"returns to event loop" -> "returns to the event loop" "no much difference" -> "not much difference"
"move the scheduling to the beginning" (2x)
"similar stuff to described above" -> "similar stuff to what's described above"
"roll our own" -> "roll your own" "can see that's" - "can see that that's"
Incorrect precedence numbers (prob. "language-wide")
"big text" -> "large amount of text" "evade problems" -> "avoid problems" "another 100 lines" -> "for the next 100 lines" "To demonstrate the approach" -> "To demonstrate this approach" "instead of syntax-highlighting" -> "instead of text-highlighting,"
"using nested `setTimeout`:" -> "using nested `setTimeout` calls:"
'The browser may even show "the script..." warning' -> 'The browser may even show a "the script..." warning'
"to react on other user actions" -> "to react to other user actions" (a little more natural sounding)
"From one hand" -> "On one hand"
"get in details" -> "get in to the details"
"if arguments count" -> "if the arguments count" "allows to easily" -> "allows us to easily" "seen in the logging example:" -> "seen in the logging example," rephrasing rest of above sentence for readability
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 9acc130
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
This PR will be closed and replaced with a new one in a few days.