Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1722 random-min-max 과제 번역 6, 8번째 줄 #1731

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#1722 random-min-max 과제 번역 6, 8번째 줄 #1731

wants to merge 2 commits into from

Conversation

librarian00
Copy link

요약

https://ko.javascript.info/number#tasks 6, 8번째 줄 solution 부분

연관 이슈

#1722

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역

@javascript-translate-bot javascript-translate-bot requested a review from a team December 1, 2023 07:24
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@librarian00 librarian00 marked this pull request as ready for review December 1, 2023 07:25
Violet-Bora-Lee
Violet-Bora-Lee reviewed Dec 1, 2023
View reviewed changes
1-js/05-data-types/02-number/8-random-min-max/solution.md
@@ -3,9 +3,9 @@ We need to "map" all values from the interval 0..1 into values from `min` to `ma
That can be done in two stages:

1. If we multiply a random number from 0..1 by `max-min`, then the interval of possible values increases `0..1` to `0..max-min`.
2. Now if we add `min`, the possible interval becomes from `min` to `max`.
2. 이제 `min`을 더하면 `min`에서 `max`가 됩니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

콤마 이후의 문장(the possible interval becomes from mintomax.) 번역이 누락되어 있습니다.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여전히 이부분이 번역이 잘 안되어있어요.
원문이 잘 반영되어있는지 위, 아래 글과 연관지어서 확인부탁드립니다.

Violet-Bora-Lee
Violet-Bora-Lee reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 달아두었습니다.

@librarian00 @Violet-Bora-Lee
Update 1-js/05-data-types/02-number/8-random-min-max/solution.md
dd6c9cf 
Co-authored-by: Bora Lee <learnerbr@gmail.com>
librarian00
librarian00 commented Dec 1, 2023
View reviewed changes
Copy link
Author

@librarian00 librarian00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바꾸겠습니다.

Violet-Bora-Lee
Violet-Bora-Lee requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 달아두었습니다.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Violet-Bora-Lee Violet-Bora-Lee Violet-Bora-Lee requested changes

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@librarian00 @CLAassistant @javascript-translate-bot @Violet-Bora-Lee