Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate 5-network/04-fetch-crossorigin #370

Merged
merged 11 commits into from
Jul 9, 2019
Merged

Translate 5-network/04-fetch-crossorigin #370

merged 11 commits into from
Jul 9, 2019

Conversation

lycheeEng
Copy link
Collaborator

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team June 14, 2019 11:04
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lycheeEng
Copy link
Collaborator Author

@leviding 这里有两句话不知道怎么翻译才好，麻烦有空的时候看一下，谢谢啦~ 🤭

@MartinsYong
Copy link
Member

校对认领~

MartinsYong
MartinsYong suggested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完毕，感谢翻译~
/done

5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
5-network/04-fetch-crossorigin/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@lycheeEng
Copy link
Collaborator Author

@MartinsYong 感谢校对！已修改完成，有个小问题麻烦再看下。

@lycheeEng
Copy link
Collaborator Author

这篇文章作者这几天有修改，晚点的时候我根据新内容再修改下翻译。
另外 5-network 这一部分有更新，这篇文章所在文件夹名字也被修改了，到时候一并修改。

@leviding
Copy link
Member

leviding commented Jul 5, 2019

@lycheeEng 是的，我让原作者提了 issue 了，有空的话，管理员可以修改更新下。

@lycheeEng
Update translation with the latest upstream update
5edd2c7 
Update translation with the latest upstream updates.
@lycheeEng
Copy link
Collaborator Author

@MartinsYong 上游内容有更新，我根据它把翻译补充了点，你要不把补上的那一点再校校？

MartinsYong
MartinsYong approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 没问题了

@lycheeEng
Copy link
Collaborator Author

@MartinsYong 感谢~

@MartinsYong
Copy link
Member

@lycheeEng 还有其他问题吗？可以merge的就先merge吧

@lycheeEng lycheeEng merged commit 7b3eec1 into master Jul 9, 2019
@lycheeEng
Copy link
Collaborator Author

已 merge，感谢大家！

@lycheeEng lycheeEng deleted the Translate-5-network/04-fetch-crossorigin branch July 9, 2019 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviding leviding leviding left review comments

@MartinsYong MartinsYong MartinsYong approved these changes

Assignees
No one assigned
Labels
DONE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lycheeEng @CLAassistant @MartinsYong @javascript-translate-bot @leviding