Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift actions activation on chat cards from none/white/red to none/red. #473

Closed
SalieriC opened this issue Aug 3, 2022 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@SalieriC
Copy link
Collaborator

SalieriC commented Aug 3, 2022

Currently actions on chat cards can have three states: disabled, active for next roll (white) and active for all rolls of that card (red). This has a very good application in the generic modifiers but for actions on cards it now doesn't make a lot of sense anymore. Usually a card represents one action and modifiers should always apply to that action. Also it gets confusing with modifiers like Wild Attack for example which the user expects to apply to trait and damage roll. Clicking twice thus is just counter-intuitive by now.

The modifiers on cards should be shifted from their current activation mode to a simpler, (hopefully) more intuitive activation mode where it either isn't (none) or is (red) active for the entire card.

@SalieriC SalieriC added the enhancement New feature or request label Aug 3, 2022
@javierriveracastro
Copy link
Owner

I have changed so that the first click red selects it. I have retained the white option, but as a third click. So users will get the most used behaviour with just one click.

I don't know if it wise, but removing features makes me feel like a gnome developer.

I you really feel that removing white is best, feel free to reopen.

@SalieriC
Copy link
Collaborator Author

I just think it isn't really needed anymore. I for once never had a player using the white option on cards and never felt the need to use it myself but I suppose it won't hurt.

@SalieriC
Copy link
Collaborator Author

SalieriC commented Dec 7, 2022

I'm going to reopen this issue as I think the generic modifiers above the chat message input should work the other way around (none -> white -> red). It makes for a minor inconsistency but I really don't think those generic modifiers should apply to all future rolls (only to the next roll for a single click). Feel free to close again if you disagree or can't stomach the inconsistency @javierriveracastro. =)

@SalieriC SalieriC reopened this Dec 7, 2022
@javierriveracastro
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants