Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create analytics-free flavor #169

Open
loicortola opened this issue Aug 2, 2018 · 9 comments
Open

Create analytics-free flavor #169

loicortola opened this issue Aug 2, 2018 · 9 comments

Comments

@loicortola
Copy link
Contributor

To help with the deployment to alternative stores like F-Droid, all tier-libraries need to be FLOSS.
We should be fine within OSM Contributor, except for the Fabric.io analytics lib.

Suggestion:
Create a flavor without the library bundled into it.
This may require some refactoring and the creation of a wrapper with a "no-op" implementation for this flavor.

This issue is related to discussions ongoing in issue #166

@rugk
Copy link

rugk commented Aug 2, 2018

Remember that you must not compile the properitary lib into the app, when you want to get on F-Droid. Just not using/disabling it with a wrapper is not enough.

@loicortola
Copy link
Contributor Author

Absolutely, although you need a wrapper interface with two implementations: one that does no-op, one that calls the library.
If we don't do this, removing the library will not compile ;)

@IzzySoft
Copy link

IzzySoft commented Feb 4, 2019

Any news on this, @loicortola? The issue at F-Droid is still stalled waiting on this.

@rugk
Copy link

rugk commented Feb 4, 2019

...or, alternatively, you switch to a FLOSS analytics library. (you get an antifeature badge then, but at least you are in F-Droid)

@IzzySoft
Copy link

IzzySoft commented Feb 5, 2019

As @rugk says. Two examples would be ACRA and Matomo, so you have some names at least.

@tuxayo
Copy link

tuxayo commented Sep 2, 2019

In the hope to move this forward a bounty has been started:

Bountysource

@hferee
Copy link

hferee commented Apr 5, 2020

I've started working on this, until I realised that Fabric is deprecated and, if I understand correctly, will be unusable in about a month from now.
Am I correct that that it is not worth making this no-op class anymore?
Should we instead focus on what analytics library you want to switch to?

@IzzySoft
Copy link

Mentioning another acceptable analytics framework from my F-Droid snippet: tracedroid (ACRA I've already mentioned above). If you stumble upon one I have not yet listed in said snippet, I gladly take hints!

@loicortola
Copy link
Contributor Author

Hello guys,

latest update for JungleBus has been made last month and upgraded Fabric to Firebase.
We would be very interested if someone wanted to submit a PR with a tracedroid-ready flavor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants