Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

API Break; #6

Closed
wants to merge 2 commits into from
Closed

API Break; #6

wants to merge 2 commits into from

Conversation

iZeaoGamer
Copy link

@iZeaoGamer iZeaoGamer commented Sep 18, 2018

Hi. This issue should fix: the rename from getDamager() to getModifier(). This was a API break that pocketmine have done over the past few weeks or months, and I just thought I'd update it to that API, and make sure to update all the plugin's problems and issues I see.
This has not been tested yet however, you may want to test this commit before merging.
If more errors occur, please let me know, and I'll do more testing myself to double check that this issue get's resolved.

UPDATES

The updates which consists:
Updating the propertie's code (onDeath) event, to double check that getModifier is now involved and added, instead of getDamager(), the pre-resistance bug which has occurred for a while, and should now be fixed.
This issue should also fix: #5
If there's anything else I need to change, then please let me know.
Thank you.

Now that Pocketmine have updated, getDamager() has been renamed to getModifier().
@JaxkDev
Copy link
Owner

JaxkDev commented Sep 18, 2018

Hi, most of my plugins have gone private to the server I now work on, but I do still accept PR’s on public work.
I will need to test this first, I’ll get back to you when I have.

@iZeaoGamer
Copy link
Author

Okay, thanks.

This whole PR was a mess. I just noticed getDamager() is different to getModifier(). I've tested similar plugins that has this part of the code and they seem to work just fine. I'm not entirely sure what happened, but this PR should fix everything relating to the issue posts you were receiving.
Let's just see how this plays out, and let me know if this fixes it or not. Thanks.
@iZeaoGamer
Copy link
Author

iZeaoGamer commented Sep 19, 2018

I just noticed getDamager() is different to getModifier(). I've tested similar plugins that has this part of the code and they seem to work just fine. I'm not entirely sure what happened, but this PR should fix everything relating to the issue posts you were receiving.
Let's just see how this plays out, and let me know if this fixes it or not. Thanks.
And sorry for any confusions there.

@ShotDead7297 ShotDead7297 mentioned this pull request Sep 19, 2018
Closed
@JaxkDev
Copy link
Owner

JaxkDev commented Sep 19, 2018

I’ll test this version also, but in reality I need to rewrite the whole plugin at some point.

@iZeaoGamer
Copy link
Author

Alright.

@JaxkDev
Copy link
Owner

JaxkDev commented Sep 20, 2018

Tests were run on latest pmmp server, and the death of someone with a valid bounty failed no message or logged message by plugin, I can only assume $cause was not of player instance.

@JaxkDev JaxkDev added the Status: Broken A feature or bug fix that is requested to be implanted but the requested code change does not work. label Sep 20, 2018
@JaxkDev
Copy link
Owner

JaxkDev commented Sep 21, 2018

So I had some time to myself and read the breaks,
I found that all I have to do is change getPlayer to getEntity.

@JaxkDev JaxkDev closed this Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Broken A feature or bug fix that is requested to be implanted but the requested code change does not work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error
2 participants