This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This issue should fix: the rename from getDamager() to getModifier(). This was a API break that pocketmine have done over the past few weeks or months, and I just thought I'd update it to that API, and make sure to update all the plugin's problems and issues I see.
This has not been tested yet however, you may want to test this commit before merging.
If more errors occur, please let me know, and I'll do more testing myself to double check that this issue get's resolved.
UPDATES
The updates which consists:
Updating the propertie's code (onDeath) event, to double check that getModifier is now involved and added, instead of getDamager(), the pre-resistance bug which has occurred for a while, and should now be fixed.
This issue should also fix: #5
If there's anything else I need to change, then please let me know.
Thank you.