Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved error when using CORS for image source #2

Closed
wants to merge 2 commits into from
Closed

resolved error when using CORS for image source #2

wants to merge 2 commits into from

Conversation

pclowes
Copy link

@pclowes pclowes commented Jan 21, 2015

By adding source.crossOrigin = $$.attr("crossorigin"), to line 16535 the face detection will now work with images that are hosted elsewhere such as AWS S3 without CORS issues.

@jaysalvat
Copy link
Owner

Great!
I can't use your pull request. The fixes must be done in src/ before building /dist.
I will try to make the change today on master and make a new release ASAP.

Thanks!

@jaysalvat
Copy link
Owner

Hello,
I add your fix in a new branch.
https://github.com/jaysalvat/jquery.facedetection/tree/cors

I can't really test it.
Can you please confirm it fixes your problem?

@jaysalvat jaysalvat reopened this Jan 21, 2015
@pclowes
Copy link
Author

pclowes commented Jan 21, 2015

Testing now, one important fix is that the crossorigin attribute on the image src must be set to: crossorigin="anonymous" or else it will take two clicks of the detection button for detection to occur. While this follows from the last fix it is a relatively unknown image attribute. I have just pushed this change as well.

@jaysalvat
Copy link
Owner

Hello,

After several tries, I didn't manage te reproduce and test that issue.
But if you say me it fixes your problem, I release it.

Do you confirm it works for you?

@jaysalvat jaysalvat closed this Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants