New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for _getaddrinfo #1

Open

jayvdb opened this issue Mar 8, 2020 · 1 comment

Owner

jayvdb commented Mar 8, 2020

rthalley/dnspython#416 needs a workaround on Windows unless a new release occurs soon.

More tests are needed in test_upstream and test_exceptions. Using gethostbyname in addition to resolver.query is the easiest way.

The text was updated successfully, but these errors were encountered:

Owner Author

jayvdb commented Sep 21, 2020

The tests in v0.3.0 do add more use of gethostbyname, but they are mostly wrapped in the socket blocker so they are hitting the cache.

The dnspython problem is fixed in v2.0, but it should still be in older dnspython.

A real test for this should be able to encounter the old bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment