Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#398 Added similar queries count #439

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

#398 Added similar queries count #439

wants to merge 3 commits into from

Conversation

nasirhjafri
Copy link
Member

No description provided.

@nasirhjafri nasirhjafri changed the title #398 Added similar queries count [WIP] #398 Added similar queries count Aug 21, 2020
@VisheshBansal
Copy link
Member

@Archmonger looks good to me. Shall we merge?

@auvipy
Copy link
Contributor

auvipy commented Sep 10, 2021

its work in progress

@Archmonger
Copy link
Contributor

@VisheshBansal this PR doesn't look complete. Would be better labeled as a draft PR.

@Archmonger Archmonger marked this pull request as draft September 10, 2021 20:20
@auvipy auvipy self-requested a review October 20, 2021 17:47
@SebCorbin
Copy link
Contributor

What's left to do? I'm willing to continue.
I would love to have a way of knowing which queries are duplicated at glance.

@SebCorbin
Copy link
Contributor

Rebased on master, added highlight on duplicate queries

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #439 (cb964c3) into master (843c898) will increase coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   86.31%   86.70%   +0.38%     
==========================================
  Files          52       53       +1     
  Lines        2090     2166      +76     
==========================================
+ Hits         1804     1878      +74     
- Misses        286      288       +2     
Impacted Files Coverage Δ
silk/sql.py 78.78% <ø> (ø)
silk/collector.py 90.00% <100.00%> (+0.29%) ⬆️
silk/migrations/0009_duplicated_queries.py 100.00% <100.00%> (ø)
silk/models.py 87.39% <100.00%> (+0.10%) ⬆️
silk/views/sql.py 97.29% <100.00%> (+0.74%) ⬆️
silk/views/sql_detail.py 95.38% <0.00%> (+1.04%) ⬆️
silk/profiling/profiler.py 91.61% <0.00%> (+2.80%) ⬆️
silk/code_generation/curl.py 53.06% <0.00%> (+5.83%) ⬆️
silk/code_generation/django_test_client.py 80.00% <0.00%> (+10.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SebCorbin SebCorbin marked this pull request as ready for review October 24, 2022 07:33
@SebCorbin SebCorbin changed the title [WIP] #398 Added similar queries count #398 Added similar queries count Oct 24, 2022
@SebCorbin SebCorbin self-assigned this Oct 26, 2022
@SebCorbin SebCorbin requested review from a team and removed request for auvipy October 28, 2022 08:47
@SebCorbin
Copy link
Contributor

Will fix #398

@SebCorbin SebCorbin mentioned this pull request Nov 9, 2022
silk/views/sql.py Outdated Show resolved Hide resolved
@SebCorbin
Copy link
Contributor

After using this PR for some time, the only feedback is UX-related, when dealing with a lot of SQL queries for a request :

  • they are paginated, so the related queries may be on another page
  • the related queries are highlighted on hover, meaning two related queries may be far apart. A checkbox would be more efficient

@SebCorbin SebCorbin marked this pull request as draft January 9, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants