-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup flake8 CI job #207
Setup flake8 CI job #207
Conversation
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 19 19
Lines 801 801
=======================================
Hits 787 787
Misses 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I don't know why this change decreased the test coverage and caused a job failure on CI. Please let me know if I need to add unit tests for the utils.py |
Added a test for utils.py in #210 |
288de2a
to
50d6fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of suggestions.
Or a better idea, let's do it using the existing pre-commit! Add this to repos:
+ - repo: https://github.com/PyCQA/flake8
+ rev: 6.0.0
+ hooks:
+ - id: flake8
+
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks: And replace name: Lint
on: [push, pull_request, workflow_dispatch]
permissions:
contents: read
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.x"
- uses: pre-commit/action@v3.0.0 |
dcacaf1
to
006a74d
Compare
006a74d
to
c35a19e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
3.1.0 ---------- - Add support for Python 3.12 - jazzband/geojson#222 - jazzband/geojson#211 - CI improvements - jazzband/geojson#217 - jazzband/geojson#212 - jazzband/geojson#207 - Unit test improvements - jazzband/geojson#215 - jazzband/geojson#210 - jazzband/geojson#209
Summary: