Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #222

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Oct 3, 2023

Dear @frewsxcv, @rayrrr, and @hugovk,

thanks a stack for conceiving and maintaining the geojson package.

Currently, it is apparently not possible to install the package on Python 3.12 without further ado, see our report at GH-221. This patch intends to improve the situation.

With kind regards,
Andreas.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #222 (c33fde1) into main (3a4a274) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          19       19           
  Lines         801      801           
=======================================
  Hits          787      787           
  Misses         14       14           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk hugovk changed the title CI: Add support for Python 3.12 Add support for Python 3.12 Oct 3, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise looks good.

CHANGELOG.rst Outdated Show resolved Hide resolved
@amotl
Copy link
Contributor Author

amotl commented Oct 6, 2023

Thank you very much for responding and approving so quickly. May I ask for the possibility to run a corresponding release, including those updates? 🙏

Referring to #221 (comment), does only @rayrrr have the capacity or powers for doing that?

@hugovk
Copy link
Member

hugovk commented Oct 6, 2023

Yes, rayrrr is the project lead (see https://jazzband.co/projects/geojson), only they can release to PyPI.

@amotl
Copy link
Contributor Author

amotl commented Oct 6, 2023

Thank you Hugo. Let's hope they are around to run a release, in order to unlock all artefacts which depend on this library.

@hugovk
Copy link
Member

hugovk commented Oct 6, 2023

I can at least merge this PR so you can install from GitHub as a workaround.

@hugovk hugovk merged commit 2e6acb7 into jazzband:main Oct 6, 2023
10 checks passed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants