Fix tests and don't invoke setup.py directly #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge of #211 failed the CI for Python 3.12:
https://github.com/jazzband/geojson/actions/runs/5098872321/jobs/9166263747
That's because the 3.12 beta removed setuptools from Python. We could install setuptools on the CI, but really we shouldn't be running tests via
python setup.py test
- we shouldn't invokesetup.py
directly. See https://blog.ganssle.io/tag/setuptools.html for the long version.Instead, let's modernise testing and use pytest and tox to run the tests.
So for example, tests can be run like:
Or with tox on all available Python versions:
Or a specific version:
Or all in parallel: