Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Replace deprecated pypy3 with pypy-3.8 #157

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 10, 2021

pypy3 is deprecated and is not available in newer images:
actions/setup-python#244 (comment)

Instead explicitly specify the version:
https://github.com/actions/setup-python#specifying-a-pypy-version

Committed via https://github.com/asottile/all-repos

TODO

  • Admin to replace this required branch check with build (pypy-3.8)

image

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #157 (6ddc77e) into master (946541f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          764       764           
  Branches       186       186           
=========================================
  Hits           764       764           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946541f...6ddc77e. Read the comment docs.

@hugovk
Copy link
Member Author

hugovk commented Mar 24, 2022

@beregond Please could you replace this required branch check with build (pypy-3.8)?

image

@beregond
Copy link
Collaborator

@hugovk yes, will do

@beregond beregond closed this Jun 16, 2022
@beregond beregond reopened this Jun 16, 2022
@beregond
Copy link
Collaborator

Okay, can't help it myself - @jezdez maybe you can help with this?

@hugovk
Copy link
Member Author

hugovk commented Jun 16, 2022

Updated to add a final, noop job to indicate success:

image

Its success depends on the build step fully passing. So instead of needing to adjust the checks each and every time a Python version is added or removed from the matrix, we can just add this new "test successful" as the required check.

@jezdez So please can you remove all the old "build" required checks and add "test successful"?

@jezdez
Copy link
Member

jezdez commented Jun 16, 2022

@hugovk Done!

@beregond beregond merged commit e157a4d into master Jun 16, 2022
@beregond beregond deleted the all-repos_autofix_all-repos-sed branch June 16, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants