Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic pre-commit config #158

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Add basic pre-commit config #158

merged 3 commits into from
Dec 4, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 10, 2021

Fixes #149.
Fixes #150.

More can be added as required (see https://pre-commit.com/hooks.html), but this adds a basic pre-commit config file to stop the check erroring PRs (e.g. #157):

image

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #158 (ce3601d) into master (48ce16b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          764       764           
  Branches       157       157           
=========================================
  Hits           764       764           
Impacted Files Coverage Δ
jsonmodels/builders.py 100.00% <100.00%> (ø)
jsonmodels/fields.py 100.00% <100.00%> (ø)
jsonmodels/models.py 100.00% <100.00%> (ø)
jsonmodels/parsers.py 100.00% <100.00%> (ø)
jsonmodels/utilities.py 100.00% <100.00%> (ø)
jsonmodels/validators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ce16b...ce3601d. Read the comment docs.

@hugovk
Copy link
Member Author

hugovk commented Nov 13, 2021

Updated to add isort and Black, for #149 and #150.

@beregond beregond merged commit 4dbb8a6 into master Dec 4, 2021
@beregond beregond deleted the add-pre-commit branch December 4, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add black Add isort
2 participants