Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thead and tbody tags #81

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Add thead and tbody tags #81

merged 1 commit into from
Nov 14, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 7, 2020

Based on kxxoling/PTable#10.

Thanks to @Sewci0 for the original PR:

Lack of and tags in _get_formatted_html_string and _get_simple_html_string made it quite hard to style using CSS.

Co-authored-by: Sewci0 <seweryn.ch@gmail.com>
@hugovk hugovk added enhancement New feature or request changelog: Added For new features labels Nov 7, 2020
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #81 (c96f072) into master (f9913bb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   87.31%   87.38%   +0.06%     
==========================================
  Files           3        3              
  Lines        1498     1506       +8     
==========================================
+ Hits         1308     1316       +8     
  Misses        190      190              
Flag Coverage Δ
GHA_Ubuntu 87.38% <100.00%> (+0.06%) ⬆️
GHA_Windows 87.38% <100.00%> (+0.06%) ⬆️
GHA_macOS 87.38% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prettytable/prettytable.py 82.39% <100.00%> (+0.13%) ⬆️
tests/test_prettytable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9913bb...c96f072. Read the comment docs.

@hugovk hugovk merged commit 86326da into jazzband:master Nov 14, 2020
@hugovk hugovk deleted the add-thead-tbody-tags branch November 14, 2020 07:40
@hugovk hugovk changed the title Add <tbody> and <thead> tags Add tbody and thead tags Nov 14, 2020
@hugovk hugovk changed the title Add tbody and thead tags Add thead and tbody tags Nov 20, 2020
hugovk added a commit that referenced this pull request Nov 20, 2020
hugovk added a commit that referenced this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant