Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version to support Django 4.2 #730

Closed
bpepple opened this issue Apr 28, 2023 · 14 comments
Closed

Release new version to support Django 4.2 #730

bpepple opened this issue Apr 28, 2023 · 14 comments

Comments

@bpepple
Copy link

bpepple commented Apr 28, 2023

Noticed support for Django 4.2 has been committed, but no release has been released to PyPi.

@JanMalte
Copy link
Contributor

@uri-rodberg @claudep is there anything blocking a new release with the recent improvments?

@uri-rodberg
Copy link
Contributor

@uri-rodberg @claudep is there anything blocking a new release with the recent improvments?

@JanMalte I'm waiting for PR #740 to be approved. But Regarding Django 4.2, it's not needed. I think if we release a new version now it should support Django 4.2.

@uri-rodberg
Copy link
Contributor

Django 4.2 has been released almost 6 months ago, and we need to support it on sorl-thumbnail. I added the above labels.

@uri-rodberg
Copy link
Contributor

Hi,

You can write in your requirements file the following line:

-e git+https://github.com/uri-rodberg/sorl-thumbnail.git@9339cc250328f7c5d00212877d920a69bf7e740a#egg=sorl_thumbnail

Or, manually run pip install -e git+https://github.com/uri-rodberg/sorl-thumbnail.git@9339cc250328f7c5d00212877d920a69bf7e740a#egg=sorl_thumbnail. This will install sorl-thumbnail from my fork with the updated commits (except one commit) and including my PR which is not merged yet. If you install this version, you can run it with Django 4.2.

@JanMalte
Copy link
Contributor

@jezdez could you please step in and help to get a new release packed?

@claudep
Copy link
Contributor

claudep commented Sep 29, 2023

I wonder why noone proposed a patch to update the Changelog 🙄

@uri-rodberg
Copy link
Contributor

I wonder why noone proposed a patch to update the Changelog 🙄

Added support for Django 4.2.
Added support for Python 3.11.
Dropped support for Python 3.7.

And also, if you accept my PR (#740), write something about it.

@claudep
Copy link
Contributor

claudep commented Oct 1, 2023

#746 for the CHANGES.rst updates.

@JanMalte
Copy link
Contributor

JanMalte commented Oct 4, 2023

@claudep @uri-rodberg if you are ok with the current master branch, I could try to make a new release.

@claudep
Copy link
Contributor

claudep commented Oct 4, 2023

Thanks @JanMalte ! I tried to trigger a release by pushing a tag, but as almost each package on which I contribute has a different release workflow, I don't remember if it was the right thing to do 😞

@uri-rodberg
Copy link
Contributor

@claudep @uri-rodberg if you are ok with the current master branch, I could try to make a new release.

Hi @JanMalte. Actually I was hoping that my PR will be merged before the new release, but I understand we need to talk about it more, so I guess it's OK to release the master branch as it is now. I don't know how to release sorl-thumbnail, but good luck!

@claudep
Copy link
Contributor

claudep commented Oct 5, 2023

Oh, the release is now available on https://jazzband.co/projects/sorl-thumbnail, but I cannot push to PyPI as I'm not a project lead. Ping @jezdez or @camilonova

@jezdez
Copy link
Member

jezdez commented Oct 5, 2023

@claudep Done.

@jezdez jezdez closed this as completed Oct 5, 2023
@claudep
Copy link
Contributor

claudep commented Oct 5, 2023

🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants