Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice on Dataset object should return another Dataset object #42

Closed
svetlyak40wt opened this issue Oct 15, 2011 · 5 comments
Closed

Slice on Dataset object should return another Dataset object #42

svetlyak40wt opened this issue Oct 15, 2011 · 5 comments
Labels

Comments

@svetlyak40wt
Copy link
Contributor

This is logical.

And Dataset have to have iter method as well, because list(dataset) results in subsequent calls to getitem and not efficient.

@kennethreitz
Copy link
Contributor

Slicing is a bit odd at the moment. I'd like revisit it entirely to be honest.

@svetlyak40wt
Copy link
Contributor Author

Well, should this task be closed as a "Won't fix"?

@kennethreitz
Copy link
Contributor

More like "opens a can of worms". There's a lot of things that I'd like to change about tablib in general...

@svetlyak40wt
Copy link
Contributor Author

Then, all these things have to be Issues. That way, contributors will be able to figure out what features or refactoring to be implemented.

@kennethreitz
Copy link
Contributor

This project is in a bit of a crisis state — it's really useful, and I use regularly. However, I wrote it several years ago and haven't touched it since. In order to get the project into a stable state I'm closing all issues and pull requests to get a "fresh slate"

Don't take this as aggressive — it's just necessary for the project to make any progress any time soon (it's pretty clear the project is effectively unmaintained at the moment). Great things to come! Please watch the GitHub logs and feel free to re-open this discussion soon. I just need to really it into a good state first.

✨ ❤️ ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants