Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the host is empty #11

Closed
0x000000FF opened this issue Mar 14, 2017 · 4 comments
Closed

the host is empty #11

0x000000FF opened this issue Mar 14, 2017 · 4 comments

Comments

@0x000000FF
Copy link

I test the browser,I found that the host string is empty(""),but my service truly published with the host string,I can get it by my python code.I need this string ,is there a way to solve this?Thanks!

@0x000000FF
Copy link
Author

in file bonjour.cpp,line 194,after
if (hAddress.protocol() == QAbstractSocket::IPv6Protocol) ref->newService->ipv6 = hAddress; else ref->newService->ip = hAddress;
I insert this line
ref->newService->host = hostName;

and it shows hostname.
thanks

@jbagg
Copy link
Owner

jbagg commented Mar 14, 2017

Yes, it looks like hostname was missing ios/macos/windows. Do you want to make a pull request for me?

@jbagg
Copy link
Owner

jbagg commented Mar 14, 2017

...the Q_UNUSED(hostName); line 180 should be removed as well.

@jbagg
Copy link
Owner

jbagg commented Mar 14, 2017

...and please use TABs only.

I'm wondering if
ref->newService->host = hostName;
(maybe on line 155 ;)
belongs in QZeroConfPrivate::resolverCallback() as hostName is just working its way to addressReply()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants