Skip to content
This repository has been archived by the owner on Nov 20, 2021. It is now read-only.

LPS-91861 Adds default invalidation cache params to prevent navigations from carrying over component state #1680

Closed
wants to merge 1 commit into from
Closed

LPS-91861 Adds default invalidation cache params to prevent navigations from carrying over component state #1680

wants to merge 1 commit into from

Conversation

jbalsas
Copy link
Owner

@jbalsas jbalsas commented Mar 11, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jbalsas
Copy link
Owner Author

jbalsas commented Mar 11, 2019

ci:test:relevant

@jbalsas
Copy link
Owner Author

jbalsas commented Mar 11, 2019

ci:test:sf

@jbalsas
Copy link
Owner Author

jbalsas commented Mar 11, 2019

Hey @john-co, could you please monitor this and send to Brian if safe?

Thanks!

@jbalsas jbalsas mentioned this pull request Mar 11, 2019
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 57 seconds 793 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6c18ae44517c36d80ca2a7ec895d5d28476fc259

Sender Branch:

Branch Name: LPS-91861
Branch GIT ID: 31a88d295cdf11dedb9d997552809214995eba91

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 57 out of 81 jobs passed in 2 hours 28 minutes 58 seconds 459 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 497a86f10f0106eb4a449ae3345f676caf100b04

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 4ca71615061f12954ae49a534528290851c51bab

57 out of 81 jobs PASSED

24 Failed Jobs:

57 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk11_open/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #286060

      Startup error: Unresolved Requirement(s)

           [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1585)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:308)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:966)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:839)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1427)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1417)
     [exec] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:943)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:258)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:770)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:682)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)
  2. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tomcat90-mysql57-jdk8/0
    Job Results:

    1 Test Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #286061
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
FrameworkEvent ERROR 
graphql.AssertException: Duplicated definition for field 'postUserAccount' in type 'Mutation'
	at graphql.schema.GraphQLObjectType.buildDefinitionMap(GraphQLObjectType.java:72)
	at graphql.schema.GraphQLObjectType.<init>(GraphQLObjectType.java:59)
	at graphql.schema.GraphQLObjectType$Builder.build(GraphQLObjectType.java:233)
	at graphql.annotations.processor.retrievers.GraphQLTypeRetriever.getGraphQLType(GraphQLTypeRetriever.java:85)
	at graphql.annotations.processor.retrievers.GraphQLObjectHandler.getObject(GraphQLObjectHandler.java:33)
	at com.liferay.portal.vulcan.internal.graphql.servlet.GraphQLServletExtender$ServletDataServiceTrackerCustomizer.addingService(GraphQLServletExtender.java:150)
	at com.liferay.portal.vulcan.internal.graphql.servlet.GraphQLServletExtender$ServletDataServiceTrackerCustomizer.addingService(GraphQLServletExtender.java:129)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
	at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:1)
	at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
	at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
	at org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
	at org.eclipse.osgi.internal.serviceregistry.FilteredServiceListener.serviceChanged(FilteredServiceListener.java:109)
	at org.eclipse.osgi.interna...
      2. PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1552335724357.log:
!SESSION 2019-03-11 20:22:24.524 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.portal.vulcan.impl 4 0 2019-03-11 20:22:24.525
        
!MESSAGE FrameworkEvent ERROR
        
!STACK 0
        
graphql.AssertException: Duplicated definition for field 'postUserAccount' in type 'Mutation'
        
at graphql.schema.GraphQLObjectType.buildDefinitionMap(GraphQLObjectType.java:72)
        
at graphql.schema.GraphQLObjectType.<init>(GraphQLObjectType.java:59)
        
at graphql.schema.GraphQLObjectType$Builder.build(GraphQLObjectType.java:233)
        
at graphql.annotations.processor.retrievers.GraphQLTypeRetriever.getGraphQLType(GraphQLTypeRetriever.java:85)
        
at graphql.annotations.processor.retrievers.GraphQLObjectHandler.getObject(GraphQLObjectHandler.java:33)
        
at com.liferay.portal.vulcan.internal.graphql.servlet.GraphQLServletExtender$ServletDataServiceTrackerCustomizer.addingService(GraphQLServletExtender.java:150)
        
at com.liferay.portal.vulcan.internal.graphql.servlet.GraphQLServletExtender$ServletDataServiceTrackerCustomizer.addingService(GraphQLServletExtender.java:129)
        
at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
        
at org.osgi.util.tracker.ServiceTracker$Tracked.cust...
  6. ...

For upstream results, click here.

@john-co
Copy link
Collaborator

john-co commented Mar 11, 2019

pushed to BChan: brianchandotcom#69319

@john-co john-co mentioned this pull request Mar 11, 2019
Closed
@john-co
Copy link
Collaborator

john-co commented Mar 11, 2019

ci:close

@jbalsas jbalsas deleted the LPS-91861 branch May 13, 2019 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbalsas @liferay-continuous-integration @john-co