Skip to content
This repository has been archived by the owner on Nov 20, 2021. It is now read-only.

LPS-61515 Create site-navigation js component and migrate navigation taglib js components #332

Closed
wants to merge 1 commit into from
Closed

LPS-61515 Create site-navigation js component and migrate navigation taglib js components #332

wants to merge 1 commit into from

Conversation

thektan
Copy link

@thektan thektan commented Dec 21, 2015

Hi @jbalsas!

The navigation taglib was migrated already (LPS-60328) and I noticed that there were js components for it as well. I'm not sure if there's anything else to add besides defining the JS-Config in the bnd file.

I also just wanted to say I appreciate the feedback you've been providing. It's really helpful in understanding not only what needs to be fixed, but the concepts behind them as well!

Thanks!

@thektan
Copy link
Author

thektan commented Dec 21, 2015

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 59 minutes 23 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 7beaef4551d3428fbbc94af8447dfd37d0f24e12

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    23 Jobs Passed.
    5 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/modules-unit
    Job Results:

    5 Tests Passed.
    1 Test Failed.

    1. test-portal-acceptance-pullrequest-batch(master) ?? 0,!master #10575

           [exec] Dec 21, 2015 4:52:01 PM org.apache.jasper.compiler.TldLocationsCache tldScanJar
           [exec] INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.
           [exec] org.apache.jasper.JasperException: file:/opt/dev/projects/github/liferay-portal/modules/apps/staging/staging-processes-web/build/unzipped-jar/META-INF/resources/publish_templates/edit_template.jsp (line: 162, column: 1) No tag "trash-undo" defined in tag library imported with prefix "liferay-ui"
           [exec] 
           [exec] Dec 21, 2015 4:52:01 PM org.apache.jasper.compiler.TldLocationsCache tldScanJar
           [exec] INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time.
           [exec] org.apache.jasper.JasperException: file:/opt/dev/projects/github/liferay-portal/modules/apps/staging/staging-processes-web/build/unzipped-jar/META-INF/resources/publish_templates/edit_template.jsp (line: 162, column: 1) No tag "trash-undo" defined in tag library imported with prefix "liferay-ui"
           [exec] :apps:staging:staging-processes-web:generateJSPJava FAILED
           [exec] 
           [exec] BUILD FAILED
           [exec] 
           [exec] Total time: 21 mins 1.29 secs
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] \* What went wrong:
           [exec] Execution failed for task ':apps:staging:staging-processes-web:generateJSPJava'.
           [exec] > Unable to compile JSPs
           [exec] 
           [exec] \* Try:
           [exec] Run with --info or --debug option to get more log output.
           [exec] 
           [exec] \* Exception is:
           [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:staging:staging-processes-web:generateJSPJava'.
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
           [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
           [exec] 	at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/4
    Job Results:

    24 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[PGCalendar#ViewCalendarTimeZoneDefaults] - Poshi Report - Poshi Summary - Console Output
  4. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/5
    Job Results:

    22 Tests Passed.
    3 Tests Failed.

    1. PoshiRunner.test[PortalconfigurationUsecase#DefaultPortalLandingPage] - Poshi Report - Poshi Summary - Console Output
    2. PoshiRunner.test[SitelocalizationUsecase#AvailableSiteLocalesSubsetOfAvailablePortalLocales] - Poshi Report - Poshi Summary - Console Output
    3. PoshiRunner.test[SitelocalizationUsecase#ViewSiteLocalizationAfterDeletingOriginalLocale] - Poshi Report - Poshi Summary - Console Output
  5. test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic
    Job Results:

    4185 Tests Passed.
    1 Test Failed.

    1. PortalLogAssertorTest.testScanXMLLog

@jbalsas
Copy link
Owner

jbalsas commented Dec 22, 2015

ci:retest

@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 56 minutes 10 seconds

Base Branch:

Branch Name: master
Branch GIT ID: 944a10a479992c29fe09744446d4a900303bbbf6

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    25 Jobs Passed.
    3 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/3
    Job Results:

    24 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[ExportImport#ExportImportSampleLARPortlet] - Poshi Report - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/4
    Job Results:

    21 Tests Passed.
    4 Tests Failed.

    1. PoshiRunner.test[PGCalendar#AddCalendarEventRegular] - Poshi Report - Poshi Summary - Console Output
    2. PoshiRunner.test[PGCalendar#DeleteCalendarEventRegular] - Poshi Report - Poshi Summary - Console Output
    3. PoshiRunner.test[PGCalendar#DeleteCalendarEventRepeatingAllFollowing] - Poshi Report - Poshi Summary - Console Output
    4. ...

    Click here for more failures.

@jbalsas
Copy link
Owner

jbalsas commented Dec 28, 2015

Hey @thektan, thanks for submitting this!

Unfortunately, I think there's been a misunderstanding here. If you look closely, the liferay-navigation-* modules are not related to the site-navigation-taglib. You can see this by searching for the string liferay-navigation throughout portal.

In this case, this module is used in:

  • site-navigation-menu-web in different templates
  • bottom_js.jspf

We could definitely do some reorganization around there, but that will be out of the scope of the taglib work we're currently doing.

Please, let me know if you have ay doubts regarding this.

Thanks again!

PS: I'm happy to provide any feedback you guys might need. Don't ever hesitate to ask for it 😉

@jbalsas jbalsas closed this Dec 28, 2015
@thektan
Copy link
Author

thektan commented Dec 28, 2015

I see! Thanks for clearing that up!

@thektan thektan deleted the LPS-61515-site-navigation-js branch February 6, 2020 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thektan @liferay-continuous-integration @jbalsas