Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphSearcher has inconsistent new line brackets #294

Closed
rickjamesthe6th opened this issue Apr 16, 2024 · 4 comments
Closed

GraphSearcher has inconsistent new line brackets #294

rickjamesthe6th opened this issue Apr 16, 2024 · 4 comments

Comments

@rickjamesthe6th
Copy link

rickjamesthe6th commented Apr 16, 2024

Class GraphSearcher methods searchInternal, search, extractScores.

Class BuildScoreProvider method pqBuildScoreProvider.

@rickjamesthe6th rickjamesthe6th changed the title GraphSearcher has inconsistent new line or brackets GraphSearcher has inconsistent new line brackets Apr 16, 2024
@jbellis
Copy link
Owner

jbellis commented Apr 16, 2024

I brace on newline when the header spans multiple lines.

Please don't open issues when the project style doesn't match your own.

@jbellis jbellis closed this as completed Apr 16, 2024
@rickjamesthe6th
Copy link
Author

I brace on newline when the header spans multiple lines.

-1

@rickjamesthe6th
Copy link
Author

rickjamesthe6th commented Apr 16, 2024

Your style aint consistent.


public SearchResult search(SearchScoreProvider scoreProvider,
                               int topK,
                               float threshold,
                               Bits acceptOrds) {
        return search(scoreProvider, topK, threshold, 0.0f, acceptOrds);
    }
    @Experimental
    public SearchResult search(SearchScoreProvider scoreProvider,
                               int topK,
                               float threshold,
                               float rerankFloor,
                               Bits acceptOrds) {
        return searchInternal(scoreProvider, topK, threshold, rerankFloor, view.entryNode(), acceptOrds);
    }

@rickjamesthe6th
Copy link
Author

rickjamesthe6th commented Apr 16, 2024

I'm happy to open PRs however these issues are being closed hastily without a proper resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants