Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Bug: -f clobbers #75

Open
xf3rno opened this issue Dec 22, 2020 · 2 comments
Open

Feature/Bug: -f clobbers #75

xf3rno opened this issue Dec 22, 2020 · 2 comments

Comments

@xf3rno
Copy link

xf3rno commented Dec 22, 2020

I finally attempted to include ~/.local/... in my dotfiles set, and as a result, lost the entire contents of the folder when running dotfiles -f -s. I realize -f is -f, but I'd expect files not present in my dotfiles repo, but present in ~/.local, to remain there.

Is this intended behavior?

It could be avoided by detecting the folder exists, not symlinking it, and instead of linking the new files individually.

The -f flag help message states "overwrite colliding dotfiles"; there was no collision in this instance, except for the top-level folder.

If not intended, the folders should be merged together.

@jbernard
Copy link
Owner

Hey Cris, this is not intended behavior, I'm sorry. Thanks for your report, I'll try to take a look at this as soon as I can and get an update pushed - please bare with me, this year has been completely insane. It's quite likely that the version in git resolves this, but a few other things have changed in that code as well. If you have time and are interested in testing it, I would greatly appreciate it.

@xf3rno
Copy link
Author

xf3rno commented Jan 7, 2021

Alright, I've noticed the discrepancy between the pip version & the latest master from some time ago. I will test the new version in my free time, will update if I see the clobber occur again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants