Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cacheing #6

Open
jbkuczma opened this issue Sep 2, 2017 · 1 comment
Open

Add cacheing #6

jbkuczma opened this issue Sep 2, 2017 · 1 comment
Labels
enhancement in progress

Comments

@jbkuczma
Copy link
Owner

jbkuczma commented Sep 2, 2017

For the Discover View, when a category is selected and viewed, those results should be cached so if they go back to that category the same results aren't being fetched again
jbkuczma added a commit that referenced this issue Sep 2, 2017
@jbkuczma
for #6 add cacheing to reduce number of network requests
c0fd42f
@jbkuczma
Copy link
Owner Author

jbkuczma commented Sep 2, 2017

c0fd42f adds a form of cacheing using UserDefaults.standard. It works, but I'm not sure if this is the right tool to use if I want to add extra features in the future that need to persist for the app's life (i.e. night mode)

@jbkuczma jbkuczma added in progress and removed to do labels Sep 3, 2017
jbkuczma added a commit that referenced this issue Sep 3, 2017
@jbkuczma
for #6 implement cache properly with NSCache and not UserDefaults
46f8dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbkuczma