Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in tutorial? #45

Closed
gavinmdouglas opened this issue May 2, 2024 · 2 comments · Fixed by #46
Closed

Typo in tutorial? #45

gavinmdouglas opened this issue May 2, 2024 · 2 comments · Fixed by #46

Comments

@gavinmdouglas
Copy link
Contributor

Hi there,

I believe this is a typo in the tutorial:

df["preference"] = [max(minenrichment, (10**df["Trial_1_AmpConc_2500"][x] + 10**df["Trial_1_AmpConc_2500"][x])/2) for x in range(len(df))]

I'm assuming that line is meant to calculate the mean of the Trial_1_AmpConc_2500 and Trial_2_AmpConc_2500, but Trial_1_AmpConc_2500 is specified each time.

Cheers,

Gavin

@jbloom
Copy link
Member

jbloom commented Jun 12, 2024

Yes, you are correct this is a typo, although it obviously only affects the tutorial, not the actual software package itself.

Thanks for catching this. Are you up for submitting a pull request to fix the tutorial typo?

@gavinmdouglas
Copy link
Contributor Author

Sure, I just made a pull request: #46

@jbloom jbloom linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants