Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some tweaks to phydms_testdivpressure #5

Closed
jbloom opened this issue Oct 1, 2016 · 0 comments
Closed

some tweaks to phydms_testdivpressure #5

jbloom opened this issue Oct 1, 2016 · 0 comments

Comments

@jbloom
Copy link
Member

jbloom commented Oct 1, 2016

  1. In the script itself, don't use file as a variable name. Replace with fname or something that isn't a Python reserved keyword.
  2. Right now the names in the final output file are funny with the directory name is something like phydms_results/ as the files get split at this underscore. Also wasn't clear to me why both file and name were needed, but maybe they are.
  3. Update the documentation to show a model comparison file with the actual output format.
@skhilton skhilton closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants