Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disabling SSL certificate verification #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ashokak
Copy link

@ashokak ashokak commented Apr 23, 2012

Since 7.10, curl will verify the certificate by default.
Users who get certificate errors should check their curl installation/configuration, and fix that, rather than connecting to anyone claiming to be FreshBooks.

(Thanks for the handy library; hope this is a useful change.)

Since 7.10, curl will verify the certificate by default.
Users who get certificate errors should check their curl installation/configuration, and fix that, rather than connecting to anyone claiming to be FreshBooks.
@jboesch
Copy link
Owner

jboesch commented Apr 23, 2012

I don't want it to check a certificate by default. I don't think most people will have this.
If you're going to make a change like this, I would rather it be configurable. Like, have it like you do by default. But if the user chooses, they can set SSL_VERIFYPEER to false.

Maybe a 3rd param to init that allows you to specify options.

$options = array(
'ssl' => false
);
FreshBooksRequest::init($domain, $token, $options);

@ashokak
Copy link
Author

ashokak commented Apr 24, 2012

Understandable.

How about this. Same secure-by-default behaviour, but instead of a bag of options to init(), an explicit method to disable the verification?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants