Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README change: corrected the "Run the Arquillian Tests" section #16

Closed
wants to merge 1 commit into from
Closed

README change: corrected the "Run the Arquillian Tests" section #16

wants to merge 1 commit into from

Conversation

rsmeral
Copy link
Contributor

@rsmeral rsmeral commented Oct 4, 2013

  • emphasized the importance of Arquillian
  • corrected and minimised the usage of the word "container" throughout the section, as it can be ambiguous
  • described configuration options of arq remote container and emphasize that it can actually be used to run tests on different machines
  • corrected usage of "test/resources/arquillian.xml" to "src/test/resources/arquillian.xml"
  • the "managed container" section incorrectly contained mentions of a remote container
  • mentioned the possibility to use JBOSS_HOME env var
  • I found the managed container section too verbose, I think there's no need for two code snippets, one is plenty

* emphasized the importance of Arquillian
* corrected and minimised the usage of the word "container" throughout the section, as it can be ambiguous
* described configuration options of arq remote container and emphasize that it can actually be used to run tests on different machines
* corrected usage of "test/resources/arquillian.xml" to "src/test/resources/arquillian.xml"
* the "managed container" section incorrectly contained mentions of a remote container
* mentioned the possibility to use JBOSS_HOME env var
* I found the managed container section too verbose, I think there's no need for two code snippets, one is plenty
@rsmeral
Copy link
Contributor Author

rsmeral commented Oct 4, 2013

These are merely suggestions, based on my feeling that the section was sometimes a bit unclear, other times too verbose. WDYT?

@sgilda
Copy link
Contributor

sgilda commented Oct 4, 2013

Other than the rendering issues, I think this is great! I'll make the same change to the EAP quickstarts. Thanks!

@sgilda sgilda closed this Oct 4, 2013
@sgilda sgilda reopened this Oct 4, 2013
@sgilda
Copy link
Contributor

sgilda commented Oct 4, 2013

This is in the section: Test the quicksrtart on a remote server. It states:

  • Arquillian's remote container adapter expects a JBoss server instance to be already started prior to the test execution.

This tells me: You must Start the JBoss server as described in the quickstart README file.

@sgilda
Copy link
Contributor

sgilda commented Oct 4, 2013

Merged.

@sgilda sgilda closed this Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants