Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functional tests for uncovered DeltaSpike quickstarts #5

Closed
wants to merge 6 commits into from
Closed

Added functional tests for uncovered DeltaSpike quickstarts #5

wants to merge 6 commits into from

Conversation

rsmeral
Copy link
Contributor

@rsmeral rsmeral commented Sep 23, 2013

Depends on updated Graphene and Drone version in wfk bom jboss-developer/jboss-wfk-boms#3

@sgilda
Copy link
Contributor

sgilda commented Sep 23, 2013

I don't see any updated instructions in the README files for the quickstarts impacted by this update. Could you add a section with instructions on how to run the functional tests, similar to the ones added in the following commit?
maschmid@4f22b62

@rsmeral
Copy link
Contributor Author

rsmeral commented Sep 23, 2013

Thanks for the reminder, I totally forgot.

@sgilda
Copy link
Contributor

sgilda commented Sep 23, 2013

Thanks @rsmeral . :-)

Ron Smeral added 2 commits September 30, 2013 17:59
* the resource-plugin execution configured the application user in AS by copying files directly to AS, so it would only work in the managed mode
* this is not really necessary because it is described in the README anyway, it just made testing easier
@pmuir
Copy link
Contributor

pmuir commented Oct 3, 2013

Code review passes, this is great stuff :-)

I tested the various tests, and I get errors on deltaspike authorization:

Failed tests:   loginTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest)

Tests in error: 
  employeeTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest): Cannot locate element using: input[value='Employees only Method']
  employeeTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest): Cannot locate element using: input[value='Logout']
  loginTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest): Cannot locate element using: input[value='Logout']
  adminTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest): Cannot locate element using: input[value='Admins only Method']
  adminTest(org.jboss.wfk.test.deltaspike.authorization.AuthorizationTest): Cannot locate element using: input[value='Logout']

Once this is fixed, I can merge this.

@sgilda
Copy link
Contributor

sgilda commented Oct 3, 2013

When I test deltaspike-authorization, I get a different result.

[INFO] No tests to run.
[INFO] Surefire report directory: /home/sgilda/GitRepos/jboss-wfk-quickstarts/deltaspike-authorization/target/surefire-reports


T E S T S

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

Looking into it further.


mvn clean verify -Parq-jbossas-remote

5. If you prefer to run the functional tests using managed instance of the JBoss server, meaning the tests will start the server for you, type fhe following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When they run the tests using a managed instance of the server, don't they need to configure the jbossHome property in the arquillian.xml file to point to the server path? The instructions are in the root README file, but you might want to point them there with something like:

NOTE: The following commands assume you have configured your Maven user settings. If you have not, you must include Maven setting arguments on the command line. See Run the Arquillian Tests for complete instructions and additional options.

@rsmeral
Copy link
Contributor Author

rsmeral commented Oct 4, 2013

@pmuir Fixed, thanks. Wrong password was used.

@sgilda That happens when you try to execute the test goal on the quickstart project. The test needs to be run in the functional-tests project. It is separated this way to avoid running the functional test by accident and to emphasize that the functional tests are something that needs special conditions (a server, a browser and an already compiled artifact to test).

@rsmeral
Copy link
Contributor Author

rsmeral commented Oct 4, 2013

@sgilda re:README: I updated the README as you suggested. Also, I checked the "Run the Arquillian tests" section which the note points to and updated that as well (#16). WDYT?

@rsmeral
Copy link
Contributor Author

rsmeral commented Oct 4, 2013

Also, if the README fix here is accepted, please fix also https://github.com/jboss-developer/jboss-wfk-quickstarts/blob/master/kitchensink-deltaspike/README.md. Thanks.

@pmuir
Copy link
Contributor

pmuir commented Oct 9, 2013

Merged.

@pmuir pmuir closed this Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants