-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functional tests for uncovered DeltaSpike quickstarts #5
Added functional tests for uncovered DeltaSpike quickstarts #5
Conversation
Depends on updated Graphene and Drone version in wfk bom jboss-developer/jboss-wfk-boms#3
I don't see any updated instructions in the README files for the quickstarts impacted by this update. Could you add a section with instructions on how to run the functional tests, similar to the ones added in the following commit? |
Thanks for the reminder, I totally forgot. |
Thanks @rsmeral . :-) |
* the resource-plugin execution configured the application user in AS by copying files directly to AS, so it would only work in the managed mode * this is not really necessary because it is described in the README anyway, it just made testing easier
Code review passes, this is great stuff :-) I tested the various tests, and I get errors on deltaspike authorization:
Once this is fixed, I can merge this. |
When I test deltaspike-authorization, I get a different result. [INFO] No tests to run. T E S T SResults : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 Looking into it further. |
|
||
mvn clean verify -Parq-jbossas-remote | ||
|
||
5. If you prefer to run the functional tests using managed instance of the JBoss server, meaning the tests will start the server for you, type fhe following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When they run the tests using a managed instance of the server, don't they need to configure the jbossHome
property in the arquillian.xml file to point to the server path? The instructions are in the root README file, but you might want to point them there with something like:
NOTE: The following commands assume you have configured your Maven user settings. If you have not, you must include Maven setting arguments on the command line. See Run the Arquillian Tests for complete instructions and additional options.
@pmuir Fixed, thanks. Wrong password was used. @sgilda That happens when you try to execute the test goal on the quickstart project. The test needs to be run in the functional-tests project. It is separated this way to avoid running the functional test by accident and to emphasize that the functional tests are something that needs special conditions (a server, a browser and an already compiled artifact to test). |
Also, if the README fix here is accepted, please fix also https://github.com/jboss-developer/jboss-wfk-quickstarts/blob/master/kitchensink-deltaspike/README.md. Thanks. |
Merged. |
Depends on updated Graphene and Drone version in wfk bom jboss-developer/jboss-wfk-boms#3