Initial commit of kitchensink ftest project #478

smiklosovic · 2013-03-19T15:25:50Z

Two tests are commented out because of https://issues.jboss.org/browse/JDF-239.

sgilda · 2013-04-03T18:37:10Z

I ran the qstool plugin against this and it reported the following issues:

kitchensink/pom.xml :
- The following dir [functional-tests] is not listed as one of project submodules
- 265 lines contain tab characters
kitchensink/functional-tests/pom.xml file : license doesn't match the template

The tab character issue is strange because I fixed all those issues upstream. When I check out the upstream version, it has no tab characters. It doesn't look like you modified that file, so I'm not sure what's going on with this.

Also, do you plan to add any information about the funtional tests to the README file? There's a "Run the Arquillian Tests" section. Maybe it would be nice to add a "Run the Functional Tests" section that talks about their purpose, how to run them, etc. Or are they not intended for developers and only for QA? I would think they would be beneficial for developers as examples of how to write functional tests for their apps. I also think we need to explain the functional-test directory.

In any event, I would like to know how to run them. I tried running 'mvn clean test -Parq-jbossas-remote' from that directory and it was apparently wrong. :-)

smiklosovic · 2013-04-03T19:59:50Z

Yes you are right with these 256 lines of tabs in pom.xml, sorry for them,
I'll fix it. Regarding licence, well, the best thing will be just
copy-paste some existing one, I do not know what I am doing wrong really.
Regarding submodule, that can be easilly done (but Pete wanted to have no
mentioning about any directories in the main pom.xml at all despite he told
me firstly it is ok to have profiles in main pom.xml which executes the
goals in ftest dir)

I have already written README but I forgot to add it to the commit, sorry
once again. When you are curious about how to execute it, you have to
firstly mvn clean package in the classic project and then enter ftest dir
and execute what you did.

I'll look at it tomorrow in work, should not take more then coule of
minutes to resolve all issues.

On Wed, Apr 3, 2013 at 8:37 PM, sgilda notifications@github.com wrote:

I ran the qstool plugin against this and it reported the following issues:

kitchensink/pom.xml :

The following dir [functional-tests] is not listed as one of
project submodules

265 lines contain tab characters

kitchensink/functional-tests/pom.xml file : license doesn't match
the template

The tab character issue is strange because I fixed all those issues
upstream. When I check out the upstream version, it has no tab characters.
It doesn't look like you modified that file, so I'm not sure what's going
on with this.

Also, do you plan to add any information about the funtional tests to the
README file? There's a "Run the Arquillian Tests" section. Maybe it would
be nice to add a "Run the Functional Tests" section that talks about their
purpose, how to run them, etc. Or are they not intended for developers and
only for QA? I would think they would be beneficial for developers as
examples of how to write functional tests for their apps. I also think we
need to explain the functional-test directory.

In any event, I would like to know how to run them. I tried running 'mvn
clean test -Parq-jbossas-remote' from that directory and it was apparently
wrong. :-)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/478#issuecomment-15855165
.

Stefan Miklosovic

sgilda · 2013-04-03T20:46:42Z

No worries. :-)

pmuir · 2013-04-26T12:53:44Z

kitchensink/functional-tests/pom.xml

+            <dependency>
+                <groupId>org.jboss.arquillian.graphene</groupId>
+                <artifactId>graphene-webdriver-impl</artifactId>
+                <version>${version.org.jboss.arquillian.graphene2}</version>


Are Graphene and Drone supported in WFK?

pmuir · 2013-04-26T12:54:45Z

Apart from checking if Graphene and Drone are supported (if they are, let's get them added to the -with-tools BOM), this looks good.

sgilda · 2013-05-02T19:02:16Z

@smiklosovic : Are we still waiting for an answer as to whether there is Graphene and Drone support in WFK?

kpiwko · 2013-05-03T12:23:47Z

Drone is supported in WFK since 2.0.0. Graphene2 didn't hit the stream yet, its 2.0.0.Final is planned for July, so it will take some time to get it in WFK.

sgilda · 2013-05-08T16:05:56Z

@smiklosovic : Karel responded. It sounds lie Drone should be added to the -with-tools BOM. Is that something you can take care of?

smiklosovic · 2013-05-08T16:55:36Z

@sgilda Not sooner than after 1.7.2013

sgilda · 2013-05-08T19:51:04Z

@smiklosovic : Does 1.7.2013 == July 1, 2013? ;-)

smiklosovic · 2013-05-08T20:05:05Z

@sgilda yes, I am taking something like long term leave. If you want to make it sooner, please redirect your request to more appropriate comitter.

sgilda · 2013-05-08T20:18:58Z

@smiklosovic : Thanks for the update. I'll check with @pmuir and see what he wants to do.

sgilda · 2013-05-14T18:10:14Z

From this, https://github.com/jboss-jdf/jboss-bom/blob/master/jboss-javaee-6.0-with-tools/pom.xml, it appears Drone has already been added.

kpiwko · 2013-05-15T07:31:42Z

Sande, yes see one of my previous comments. Still, while we have Drone in WFK, we do not have Graphene 2 there. So we can't really proceed here.

sgilda · 2013-08-02T15:35:31Z

Just checked with Lukas. Graphene 2 is currently in Alpha, soon to be Beta.

pmuir · 2013-08-19T15:25:40Z

@kpiwko @smiklosovic @maschmid we can proceed with this now. Can you check if the PR is up to date, and then we can merge.

sgilda · 2013-08-20T19:55:16Z

I just tried the functional tests with the following errors. It could be something I'm doing wrong.

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 10.370s
[INFO] Finished at: Tue Aug 20 15:51:02 EDT 2013
[INFO] Final Memory: 29M/329M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.4.3:test (default-test) on project jboss-as-kitchensink-test-webdriver: There are test failures.
[ERROR]
[ERROR] Please refer to /home/sgilda/GitRepos/quickstart-jdf/kitchensink/functional-tests/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]

Surefire reports contains this:

Test set: org.jboss.as.quickstarts.kitchensink.test.webdriver.KitchensinkTest

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.536 sec <<< FAILURE!
org.jboss.as.quickstarts.kitchensink.test.webdriver.KitchensinkTest Time elapsed: 0 sec <<< ERROR!
java.lang.RuntimeException: Could not invoke deployment method: public static org.jboss.shrinkwrap.api.spec.WebArchive org.jboss.as.quickstarts.kitchensink.test.webdriver.KitchensinkTest.createDeployment()
at org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.invoke(AnnotationDeploymentScenarioGenerator.java:160)
at org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.generateDeployment(AnnotationDeploymentScenarioGenerator.java:94)
at org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.generate(AnnotationDeploymentScenarioGenerator.java:57)
at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)
;;;;
Caused by: java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at org.jboss.arquillian.container.test.impl.client.deployment.AnnotationDeploymentScenarioGenerator.invoke(AnnotationDeploymentScenarioGenerator.java:156)
... 54 more
Caused by: java.lang.IllegalArgumentException: File for import exist: /home/sgilda/GitRepos/quickstart-jdf/kitchensink/functional-tests/../target/jboss-as-kitchensink.war
at org.jboss.shrinkwrap.api.ArchiveFactory.createFromZipFile(ArchiveFactory.java:179)
at org.jboss.shrinkwrap.api.ShrinkWrap.createFromZipFile(ShrinkWrap.java:185)
at org.jboss.as.quickstarts.kitchensink.test.webdriver.KitchensinkTest.createDeployment(KitchensinkTest.java:76)
... 59 more

There are no messages in the JBoss server log.

smiklosovic · 2013-08-20T23:16:44Z

File for import exist: /home/sgilda/GitRepos/quickstart-jdf/kitchensink/functional-tests/../target/jboss-as-kitchensink.war

it means this war does not exist, it seems you have to build the project itself with mvn clean package, then go to ftest dir and execute mvn test -Psome-profile (note there is not clean goal!)

sgilda · 2013-08-20T23:55:58Z

@smiklosovic : That did it. I think you need to add this information to the README file. I had done mvn clean package jboss-as:deploy as described above, but that apparently wasn't enough.

Would you mind modifying the section 'Run the Arquillian Functional Tests' to be in step format, similar to the 'Run the Arquillian Tests' section?

Maybe something like the followinge:

Run the Arquillian Functional Tests

This quickstart provides Arquillian functional tests as well. They are located under the directory "functional-tests". Functional tests verify that your application behaves correctly from the user's point of view - simulating clicking around the page as a normal user would do.

To run these tests, you must build the main project as described above.

Open a command line and navigate to the root directory of this quickstart.
Build the quickstart WAR using the following command:
```
mvn clean package
```
Navigate to the functional-tests/ directory in this quickstart.
If you have a running instance of the JBoss Server, as described above, run the remote tests by typing the following command:
```
mvn clean test -Parq-jbossas-remote
```
If you prefer to run the functional tests using managed instance of the JBoss server, meaning the tests will start the server for you, type fhe following command:
```
mvn clean test -Parq-jbossas-managed
```

kpiwko · 2013-08-21T06:51:25Z

Let's change the approach. WFK now supports Maven Resolver, so there is no need to rely on mvn clean package to build the WAR for you. You can let test build the war on its own. So basically steps 1-2 won't be needed anymore and also tests will work ootb from IDE

maschmid · 2013-08-21T11:03:36Z

I think a functional test should be black box test, and as such cannot build its WAR itself, as there would be no guarantee the result is the same as what maven builds. It should test the exact binary an end user is going to deploy.

maschmid · 2013-08-21T11:10:49Z

Anyway, let's close this PR, I'll fix the other issues and open another pull request with the updates.

sgilda · 2013-08-21T16:27:23Z

@maschmid. @smiklosovic : Are you saying this needs some modifications before it will run as you expect? I will close this as you requested.

…ransaction-remote-call-s2i-fix [WFLY-12904] s2i build fix for quickstart ejb-txn-remote-call

Initial commit of kitchensink ftest project

297106e

Stefan Miklosovic added 2 commits April 19, 2013 14:16

Refactored ftest project of kitchensink quickstart

0351b5c

removed module element

2e453ea

pmuir reviewed Apr 26, 2013
View reviewed changes

sgilda closed this Aug 21, 2013

fjuma pushed a commit to fjuma/quickstart that referenced this pull request Aug 11, 2022

Merge pull request jboss-developer#478 from ochaloup/WFLY-12904-ejb-t…

8cfb6b3

…ransaction-remote-call-s2i-fix [WFLY-12904] s2i build fix for quickstart ejb-txn-remote-call

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit of kitchensink ftest project #478

Initial commit of kitchensink ftest project #478

smiklosovic commented Mar 19, 2013

sgilda commented Apr 3, 2013

smiklosovic commented Apr 3, 2013

sgilda commented Apr 3, 2013

pmuir Apr 26, 2013

pmuir commented Apr 26, 2013

sgilda commented May 2, 2013

kpiwko commented May 3, 2013

sgilda commented May 8, 2013

smiklosovic commented May 8, 2013

sgilda commented May 8, 2013

smiklosovic commented May 8, 2013

sgilda commented May 8, 2013

sgilda commented May 14, 2013

kpiwko commented May 15, 2013

sgilda commented Aug 2, 2013

pmuir commented Aug 19, 2013

sgilda commented Aug 20, 2013

smiklosovic commented Aug 20, 2013

sgilda commented Aug 20, 2013

kpiwko commented Aug 21, 2013

maschmid commented Aug 21, 2013

maschmid commented Aug 21, 2013

sgilda commented Aug 21, 2013

Initial commit of kitchensink ftest project #478

Initial commit of kitchensink ftest project #478

Conversation

smiklosovic commented Mar 19, 2013

sgilda commented Apr 3, 2013

smiklosovic commented Apr 3, 2013

sgilda commented Apr 3, 2013

pmuir Apr 26, 2013

Choose a reason for hiding this comment

pmuir commented Apr 26, 2013

sgilda commented May 2, 2013

kpiwko commented May 3, 2013

sgilda commented May 8, 2013

smiklosovic commented May 8, 2013

sgilda commented May 8, 2013

smiklosovic commented May 8, 2013

sgilda commented May 8, 2013

sgilda commented May 14, 2013

kpiwko commented May 15, 2013

sgilda commented Aug 2, 2013

pmuir commented Aug 19, 2013

sgilda commented Aug 20, 2013

Test set: org.jboss.as.quickstarts.kitchensink.test.webdriver.KitchensinkTest

smiklosovic commented Aug 20, 2013

sgilda commented Aug 20, 2013

Run the Arquillian Functional Tests

kpiwko commented Aug 21, 2013

maschmid commented Aug 21, 2013

maschmid commented Aug 21, 2013

sgilda commented Aug 21, 2013