Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid the usage of the default package in the project generation #671

Closed
cescoffier opened this issue Jan 30, 2019 · 1 comment
Closed

Forbid the usage of the default package in the project generation #671

cescoffier opened this issue Jan 30, 2019 · 1 comment
Labels
kind/enhancement New feature or request
Milestone
0.8.0

Comments

@cescoffier
Copy link
Member

The project generation should forbid the usage of the default package, for 2 reasons:

  1. it's a bad practice
  2. it does not work ;-)
@cescoffier cescoffier added the kind/enhancement New feature or request label Jan 30, 2019
@cescoffier
Copy link
Member Author

The mojo should detect this case and inject a package name.

@cescoffier cescoffier mentioned this issue Jan 30, 2019
Merged
cescoffier added a commit that referenced this issue Feb 2, 2019
@cescoffier
Fix issues #670, #671, #672, #673 and #675
40e9de4 
* #670 - improve the decision about the project location
* #671 - when the user does not specify a package, a package name is generated either from the passed groupId or using the default value
* #672 - use the Prompter to get user values, this is disabled in batch mode
* #673 - if the user modifies an existing project, the user is not allowed to pass GAV. Now this case it detected and the build is failed
* #675 - if the user modifies an existing project the GAV are retrieved from the existing project.
@gsmet gsmet closed this as completed Feb 3, 2019
@cescoffier cescoffier added this to the 0.8.0 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@cescoffier @gsmet