Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Maven plugin should fail when GAV is set and existing project exists #673

Closed
cescoffier opened this issue Jan 30, 2019 · 0 comments
Closed

The Maven plugin should fail when GAV is set and existing project exists #673

cescoffier opened this issue Jan 30, 2019 · 0 comments
Labels
kind/enhancement New feature or request
Milestone
0.8.0

Comments

@cescoffier
Copy link
Member

If the user has an existing project and passes the GAV to the CreateProjectMojo the build should fail.
@cescoffier cescoffier added the kind/enhancement New feature or request label Jan 30, 2019
@cescoffier cescoffier added this to the 0.8.0 milestone Jan 30, 2019
@cescoffier cescoffier mentioned this issue Jan 30, 2019
Merged
cescoffier added a commit that referenced this issue Feb 2, 2019
@cescoffier
Fix issues #670, #671, #672, #673 and #675
40e9de4 
* #670 - improve the decision about the project location
* #671 - when the user does not specify a package, a package name is generated either from the passed groupId or using the default value
* #672 - use the Prompter to get user values, this is disabled in batch mode
* #673 - if the user modifies an existing project, the user is not allowed to pass GAV. Now this case it detected and the build is failed
* #675 - if the user modifies an existing project the GAV are retrieved from the existing project.
@gsmet gsmet closed this as completed Feb 3, 2019
maxandersen added a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
@maxandersen
feat: support for BOM POM's i.e. maven dependencyManagement (quarkusi…
2d81c74 
…o#673)

jbang will now if and only if the very first dependency has a `@pom`
classifier, download it and load it as pom file in shrinkwrap.

Example:

```java
//DEPS io.quarkus:quarkus-bom:1.11.0.Final@pom
//DEPS io.quarkus:quarkus-resteasy
//DEPS io.quarkus:quarkus-smallrye-openapi
//DEPS io.quarkus:quarkus-swagger-ui
```

Then that pom file dependency management (and dependencies) gets listened to.

Fixes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@cescoffier @gsmet