Fix a few maven generation regressions #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supports only read-only, read-write and nonstrict-read-write access for entity, collection and natural id caches. * Supports query caching. * Supports extended cache statistics. * Contains functional and stress tests. * Supports configurable maximum region size (in terms of number of entries), and maximum idle time for cache eviction.
…with docker (sounds obvious)
…variables are not substituted
…lity This is related to #543
* #670 - improve the decision about the project location * #671 - when the user does not specify a package, a package name is generated either from the passed groupId or using the default value * #672 - use the Prompter to get user values, this is disabled in batch mode * #673 - if the user modifies an existing project, the user is not allowed to pass GAV. Now this case it detected and the build is failed * #675 - if the user modifies an existing project the GAV are retrieved from the existing project.
* use {project-name} instead of Protean
* rephrase the part on junit 5 and surefire
- log a warning message when an extension template attempts to use a removed bean - resolves #658
gsmet
reviewed
Jan 30, 2019
| @Component | ||
| private Prompter prompter; | ||
|
|
||
| @Override | ||
| public void execute() throws MojoExecutionException { | ||
| File projectRoot = new File("."); | ||
| File pom = new File(projectRoot, "pom.xml"); | ||
|
|
||
| if (pom.isFile()) { |
There was a problem hiding this comment.
Didn't we decide to remove the ability to do that?
There was a problem hiding this comment.
I've opened an issue about it. Waiting for the discussion to happen.
There was a problem hiding this comment.
Actually, I believe we can schedule the removal for the next release (0.9.0).
* Fixed nonstrict test case so that it can be executed manually. * Changed default log4j2 logging levels to error. The file should eventually be removed.
…n-fixes Various documentation fixes
Gracefully stop rather than hang when there are no steps
|
@gsmet can you have a look, CI passed. |
Now, not passing className disable the resource generation
Agroal tidying/bugfix
Fix Hibernate cache random failures #694
Move off freemarker
gsmet
reviewed
Feb 1, 2019
| -DprojectGroupId=my-groupId \ | ||
| -DprojectArtifactId=my-artifactId \ | ||
| -DprojectVersion=my-version \ | ||
| -DclassName="org.my.group.MyResource" | ||
| ---- | ||
|
|
||
| NOTE: If you just launch `mvn org.jboss.shamrock:shamrock-maven-plugin:{shamrock-version}:create` the Maven plugin ask |
cli/maven/src/main/java/org/jboss/shamrock/maven/CreateProjectMojo.java
Outdated
Show resolved
Hide resolved
Caffeine Extension
Create a JAX-RS - JSON extension relying on JSON-B and JSON-P
Eclipse apt fixes
Netty extension
* interactive mode * made groupId optional (and changed the default)
* #670 - improve the decision about the project location * #671 - when the user does not specify a package, a package name is generated either from the passed groupId or using the default value * #672 - use the Prompter to get user values, this is disabled in batch mode * #673 - if the user modifies an existing project, the user is not allowed to pass GAV. Now this case it detected and the build is failed * #675 - if the user modifies an existing project the GAV are retrieved from the existing project.
When no classname is passed, it indicates that the resource class and the associated test must not be created.
Now, not passing className disable the resource generation
* interactive mode * made groupId optional (and changed the default)
With the log location change, most of the test fails because the project is not created in the current directory but in a directory named $artifactId.
…m:cescoffier/protean-shamrock into features/fix-maven-generation-regressions
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues #670, #671, #672, #673, #675 and #706
pom.xml#675 - if the user modifies an existing project the GAVs are retrieved from the existing project.