Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-2679] narayna-full to contain bits of jbossxts #1014

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented May 25, 2016

https://issues.jboss.org/browse/JBTM-2679

!QA_JTA !QA_JTS_JDKORB !BLACKTIE !PERF !MAIN

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@tomjenkinson
Copy link
Member

The failure was caused by:
consoleText.zip

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 1, 2016

hm... I'm a bit lost here. What influence could have change in narayana-full for compensations module?

I've rerun the compilation and the tests on my machine and I can't see the reffered exception.
My investigation on the stack trace was not much informative either. The error which seems caused the test failure is com.arjuna.wst.SystemException: com.arjuna.wsc.InvalidStateException: ARJUNA042083: Invalid coordination context state. Some kind of test instability?

I would like to left this being retested and then would see.

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 1, 2016

retest this please

@tomjenkinson
Copy link
Member

it could be because compensations may have a dependency on XTS: @gytis do you have any suggestion?

@jbosstm-bot
Copy link

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 1, 2016

I see. Just I thought that narayna-full is a module independent on other modules. It's built as last one and means like "create a distro".

@jbosstm-bot
Copy link

@tomjenkinson
Copy link
Member

ah, I think this is because we can't test XTS on 5.2 branch now (we can build it) - please can I ask you to raise this on master instead of 5.2 then we can just backport it. I think we need a JBTM-2679 for the backport unless 7.1 is fine.

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 1, 2016

Sure, I've created PR #1017 that targets master. I hope I'll be more lucky with the new one ;)

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 3, 2016

Test for this change passed on master branch (see #1017)

@tomjenkinson
Copy link
Member

Great - do you need a JBEAP as this is 5.2 branch?

@ochaloup
Copy link
Contributor Author

ochaloup commented Jun 6, 2016

Nope, from my point this small change is perfectly fine without JBEAP. But depends. I don't know if this would not break productization process or something if there is not JBEAP.

For me this is fine as JBTM.

@tomjenkinson tomjenkinson merged commit 04768c4 into jbosstm:5.2 Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants