-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBTM-2679] narayna-full to contain bits of jbossxts #1014
Conversation
…ild of XTS folder
Started testing this pull request with XTS profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=XTS,jdk=jdk8.latest,label=linux/1510/ |
XTS profile tests failed (http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=XTS,jdk=jdk8.latest,label=linux/1510/): compensations build failed |
The failure was caused by: |
hm... I'm a bit lost here. What influence could have change in narayana-full for compensations module? I've rerun the compilation and the tests on my machine and I can't see the reffered exception. I would like to left this being retested and then would see. |
retest this please |
it could be because compensations may have a dependency on XTS: @gytis do you have any suggestion? |
Started testing this pull request with XTS profile: http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=XTS,jdk=jdk8.latest,label=linux/1515/ |
I see. Just I thought that |
XTS profile tests failed (http://albany.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-jdk8/PROFILE=XTS,jdk=jdk8.latest,label=linux/1515/): compensations build failed |
ah, I think this is because we can't test XTS on 5.2 branch now (we can build it) - please can I ask you to raise this on master instead of 5.2 then we can just backport it. I think we need a JBTM-2679 for the backport unless 7.1 is fine. |
Sure, I've created PR #1017 that targets master. I hope I'll be more lucky with the new one ;) |
Test for this change passed on master branch (see #1017) |
Great - do you need a JBEAP as this is 5.2 branch? |
Nope, from my point this small change is perfectly fine without JBEAP. But depends. I don't know if this would not break productization process or something if there is not JBEAP. For me this is fine as JBTM. |
https://issues.jboss.org/browse/JBTM-2679
!QA_JTA !QA_JTS_JDKORB !BLACKTIE !PERF !MAIN