Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-3087 Ensure the LRA implementation is up to date (including new … #1443

Merged
merged 3 commits into from
Apr 26, 2019

Conversation

mmusgrov
Copy link
Member

@mmusgrov mmusgrov commented Apr 18, 2019

…context propagation semantics)
https://issues.jboss.org/browse/JBTM-3117

The biggest change was to accomodate the change in behaviour of LRA context propagation (eclipse/microprofile-lra#132)

!QA_JTA !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !QA_JTS_JACORB !BLACKTIE !XTS !PERF NO_WIN !AS_TESTS !TOMCAT !JACOCO !mysql !postgres !db2 !oracle !RTS

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@mmusgrov mmusgrov requested a review from ochaloup April 23, 2019 08:26
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small question about licensing

* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*******************************************************************************/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This exception classes are taken from the specification which is under ASL 2.0 but Narayana is licensed under LGPL 2.1. I am not sure if this is a problem I just wanted to highlight it.

Also copyright should probably have year 2019?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the eclipse exception classes and mappers.
Thanks for the review.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Copy link
Contributor

@ochaloup ochaloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusgrov Sorry for the late review. I was sick.

No trouble from my side.

@mmusgrov mmusgrov merged commit f487c5a into jbosstm:master Apr 26, 2019
@mmusgrov mmusgrov deleted the JBTM-3087 branch April 29, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants