Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBTM-3150 Upgrade maven version to 3.6.1 #1453

Merged
merged 2 commits into from
Jun 4, 2019
Merged

Conversation

mmusgrov
Copy link
Member

@mmusgrov mmusgrov commented May 31, 2019

https://issues.jboss.org/browse/JBTM-3150

!QA_JTA !QA_JTS_JDKORB !QA_JTS_OPENJDKORB !QA_JTS_JACORB BLACKTIE !XTS !PERF !AS_TESTS !TOMCAT !JACOCO !LRA !DB_TESTS !JDK11 !WIN !BLACKTIE
RTS LRA

@mmusgrov mmusgrov force-pushed the JBTM-3150 branch 2 times, most recently from efe1775 to dcfb5d4 Compare May 31, 2019 13:22
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm jbosstm deleted a comment from jbosstm-bot May 31, 2019
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@mmusgrov
Copy link
Member Author

mmusgrov commented Jun 3, 2019

  • two points more. there was removed the arquillian-swarm.xml. it could not be needed (but e.g. it defines a way to run the test with more verbose logging) but if stated to not be needed it should not be mentioned as arquillian-thorntail.xml in pom.xml

Not sure what this means but all I did was replace arquillian-swarm.xml with arquillian-thorntail.xml

@jbosstm-bot
Copy link

@mmusgrov
Copy link
Member Author

mmusgrov commented Jun 4, 2019

@ochaloup So I think I have addressed your concerns may I go ahead and merge?

Copy link
Contributor

@ochaloup ochaloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delayed review.

The last thing is, there is need to rename the rts/lra/lra-test/tck/src/test/resources/arquillian-swarm.xml to rts/lra/lra-test/tck/src/test/resources/arquillian-thorntail.xml. Otherwise the tck mvn verify -Parq does not work.

@mmusgrov
Copy link
Member Author

mmusgrov commented Jun 4, 2019

@ochaloup There is no file called rts/lra/lra-test/tck/src/test/resources/arquillian-swarm.xml in this PR

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@mmusgrov mmusgrov merged commit 5b6f9a0 into jbosstm:master Jun 4, 2019
@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants